Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7804 closed (invalid)

newforms.fields.UploadedFile Invalid Deprecation warning.

Reported by: CollinAnderson Owned by:
Component: Forms Version: master
Severity: Keywords: 2070-fix
Cc: cmawebsite@… Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I'm not sure if anyone has noticed this yet, but in [7814],
newforms.fields.UploadedFile.content was changed to
newforms.fields.UploadedFile.data without being listed on
BackwardsIncompatibleChanges or raising a deprecation warning. However
the [7859] change has a deprecation warning for the UploadedFile.data
attribute, which was only in there for 45 revisions. It would be nice
to also have a deprecation warning for UploadedFile.content.

http://code.djangoproject.com/wiki/BackwardsIncompatibleChanges#Uploa...
http://code.djangoproject.com/changeset/7814
http://code.djangoproject.com/changeset/7859

Change History (7)

comment:1 Changed 7 years ago by ericholscher

  • milestone set to post-1.0
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to ericholscher
  • Patch needs improvement unset
  • Status changed from new to assigned

This change was only in for 45 revisions, I don't think it needs to be in the wiki. If you can find a good place to put it in, go ahead and change it. It's a wiki afterall :)

comment:2 Changed 7 years ago by ericholscher

  • Owner ericholscher deleted
  • Status changed from assigned to new
  • Triage Stage changed from Unreviewed to Someday/Maybe

comment:3 Changed 7 years ago by CollinAnderson

Well what I am saying is that the change listed on the wiki is that [7814] changed the newforms uploaded file interface from .content to .data, and [7859] changes the interface from .data to read(), and only the .data to read() backwards incompatibility is listed. It seems to me that either the documented backwards incompatibility should be from .content to .data, and .data to .read(), or just .content to .read(), but the .content to .data change is not listed at all.

comment:4 Changed 7 years ago by CollinAnderson

  • Component changed from Uncategorized to django.newforms
  • milestone post-1.0 deleted
  • Summary changed from newforms.fields.UploadedFile Undocumented Backwards Incompatible change to newforms.fields.UploadedFile Invalid Deprecation warning.
  • Triage Stage changed from Someday/Maybe to Unreviewed

The deprecated .data attribute that was only in there for 45 revisions gives a warning if you use it, but the .content attribute that has been in there for almost a year gives an attribute error.

comment:5 Changed 7 years ago by ericholscher

  • milestone set to 1.0 maybe
  • Triage Stage changed from Unreviewed to Design decision needed

comment:6 Changed 7 years ago by jacob

  • Resolution set to invalid
  • Status changed from new to closed

We've since removed (or should have removed) all the deprecation warnings in prep for 1.0, so this is no longer valid.

comment:7 Changed 7 years ago by anonymous

  • milestone 1.0 maybe deleted

Milestone 1.0 maybe deleted

Note: See TracTickets for help on using tickets.
Back to Top