Opened 16 years ago

Closed 16 years ago

Last modified 13 years ago

#7775 closed (fixed)

Duplicate authentication code in Newforms-Admin

Reported by: Michael Newman Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Keywords: auth admin
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The contrib.auth.login function sets the last_login time for the user. contrib.admin.sites.login calls login and then sets the user's last_login time essentially duplicating code. The patch removes 2 lines of duplicate code and a TODO asking to accomplish the last login with an event, which, I believe, is now unnecessary.

Attachments (1)

7775-duplicate-auth-code.diff​ (680 bytes ) - added by Michael Newman 16 years ago.

Download all attachments as: .zip

Change History (5)

by Michael Newman, 16 years ago

Attachment: 7775-duplicate-auth-code.diff​ added

comment:1 by Michael Newman, 16 years ago

Summary: Duplicate authencation code in Newforms Admin → Duplicate authentication code in Newforms-Admin

comment:2 by Simon Greenhill, 16 years ago

milestone: → 1.0 beta
Triage Stage: Unreviewed → Ready for checkin

comment:3 by Russell Keith-Magee, 16 years ago

Resolution: → fixed
Status: new → closed

(In [8006]) Fixed #7775 -- Removed some duplicated code from the admin login sequence. Thanks to Mnewman for the report.

comment:4 by Jacob, 13 years ago

milestone: 1.0 beta

Milestone 1.0 beta deleted

Note: See TracTickets for help on using tickets.
Back to Top