Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#7775 closed (fixed)

Duplicate authentication code in Newforms-Admin

Reported by: Mnewman Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Keywords: auth admin
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


The contrib.auth.login function sets the last_login time for the user. contrib.admin.sites.login calls login and then sets the user's last_login time essentially duplicating code. The patch removes 2 lines of duplicate code and a TODO asking to accomplish the last login with an event, which, I believe, is now unnecessary.

Attachments (1)

7775-duplicate-auth-code.diff (680 bytes) - added by Mnewman 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by Mnewman

comment:1 Changed 7 years ago by Mnewman

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Summary changed from Duplicate authencation code in Newforms Admin to Duplicate authentication code in Newforms-Admin

comment:2 Changed 7 years ago by Simon Greenhill

  • milestone set to 1.0 beta
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:3 Changed 7 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [8006]) Fixed #7775 -- Removed some duplicated code from the admin login sequence. Thanks to Mnewman for the report.

comment:4 Changed 4 years ago by jacob

  • milestone 1.0 beta deleted

Milestone 1.0 beta deleted

Note: See TracTickets for help on using tickets.
Back to Top