Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#7775 closed (fixed)

Duplicate authentication code in Newforms-Admin

Reported by: Michael Newman Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Keywords: auth admin
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The contrib.auth.login function sets the last_login time for the user. contrib.admin.sites.login calls login and then sets the user's last_login time essentially duplicating code. The patch removes 2 lines of duplicate code and a TODO asking to accomplish the last login with an event, which, I believe, is now unnecessary.

Attachments (1)

7775-duplicate-auth-code.diff (680 bytes) - added by Michael Newman 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Michael Newman

comment:1 Changed 8 years ago by Michael Newman

Summary: Duplicate authencation code in Newforms AdminDuplicate authentication code in Newforms-Admin

comment:2 Changed 8 years ago by Simon Greenhill

milestone: 1.0 beta
Triage Stage: UnreviewedReady for checkin

comment:3 Changed 8 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [8006]) Fixed #7775 -- Removed some duplicated code from the admin login sequence. Thanks to Mnewman for the report.

comment:4 Changed 5 years ago by Jacob

milestone: 1.0 beta

Milestone 1.0 beta deleted

Note: See TracTickets for help on using tickets.
Back to Top