Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#7751 closed (fixed)

Don't assume that connection.autocommit is a callable

Reported by: Leo Soto M. Owned by: nobody
Component: Uncategorized Version: master
Severity: Keywords: jython, db-be-api
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: UI/UX:

Description

source:django/trunk/django/test/utils.py assumes that connection.autocommit is going to be a callable. This is not true for some backends where it is a property (basically all JDBC based backends, also PyODBC and cx_Oracle).

The attached patch fixes this by taking into account the case where autocommit is a property.

Attachments (1)

autocommit.diff (672 bytes) - added by Leo Soto M. 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by Leo Soto M.

Attachment: autocommit.diff added

comment:1 Changed 8 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [7940]) Fixed #7751 -- Added check to allow for the fact that autocommit can be a property, rather than a function on certain database backends. Thanks to Leo Soto for the fix.

comment:2 Changed 5 years ago by Jacob

milestone: 1.0 beta

Milestone 1.0 beta deleted

Note: See TracTickets for help on using tickets.
Back to Top