Code

Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#7751 closed (fixed)

Don't assume that connection.autocommit is a callable

Reported by: leosoto Owned by: nobody
Component: Uncategorized Version: master
Severity: Keywords: jython, db-be-api
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: UI/UX:

Description

source:django/trunk/django/test/utils.py assumes that connection.autocommit is going to be a callable. This is not true for some backends where it is a property (basically all JDBC based backends, also PyODBC and cx_Oracle).

The attached patch fixes this by taking into account the case where autocommit is a property.

Attachments (1)

autocommit.diff (672 bytes) - added by leosoto 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by leosoto

comment:1 Changed 6 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [7940]) Fixed #7751 -- Added check to allow for the fact that autocommit can be a property, rather than a function on certain database backends. Thanks to Leo Soto for the fix.

comment:2 Changed 3 years ago by jacob

  • milestone 1.0 beta deleted

Milestone 1.0 beta deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.