Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#7744 closed (fixed)

cache.add() should return result

Reported by: qmanic Owned by: nobody
Component: Core (Cache system) Version: master
Severity: Keywords: cache add
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Currently, cache.add() doesn't have a documented return type and for most backends doesn't return anything useful.

I think it should return something, though I'm unsure as to what. For example, in the memcached libraries we call, add() returns True or False depending on whether the key gets added or not.

One of the reasons behind this is so that locking can be emulated through the cache with a single add() call. Currently you'd have to add() some unique value, then get() it back out and compare the values.

Attachments (1)

7744-1.diff (4.5 KB) - added by Matt McClanahan 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Matt McClanahan

Attachment: 7744-1.diff added

comment:1 Changed 8 years ago by Matt McClanahan

Has patch: set
Triage Stage: UnreviewedDesign decision needed

Since the functionality of add() was based on memcached's implementation to begin with, it seems reasonable to do so here as well.

comment:2 Changed 8 years ago by Michael Radziej

milestone: post-1.0

comment:3 Changed 8 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

Whoops. I hadn't noticed this existed. I needed to fix this yesterday as a consequence of something else, so it was fixed in [8278].

comment:4 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top