Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#7714 closed (fixed)

corrected documentation for {% url %} resolver

Reported by: V Owned by: nobody
Component: Documentation Version: master
Severity: Keywords: url resolver
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description (last modified by mtredinnick)

there were two errors:

  1. ('^client/(\d+)/$', 'app_name.app_views.client') originally ('^client/(\d+)/$', 'app_views.client')

gives you an ImportError (ViewDoesNotExist)

  1. {% url app_name.app_views.client client.id %} originally {% url app_views.client client.id %}

simply doesn't work

to check I did:

  1. startapp app_name
  2. add urls.py to the main urls.py as in the docs
  3. add urls.py to app_name/urls.py as shown above
  4. creates app_views.py with view client that gives back {% url app_views.client client.id %}

Attachments (2)

patch.txt (884 bytes) - added by Viktor <viktor.nagy@…> 7 years ago.
7714.url_tag_doc.diff (829 bytes) - added by julien 7 years ago.
Revised Viktor's patch, adding 'project_name' to the paths

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by Viktor <viktor.nagy@…>

comment:1 Changed 7 years ago by mtredinnick

  • Description modified (diff)
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Unbroke description.

comment:2 Changed 7 years ago by garcia_marc

  • milestone set to 1.0
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

I agree on that, but I think that to correct it isn't enough to add the application name, it's also needed to add the project name.

So app_views.client should be project_name.app_name.app_views.client

Changed 7 years ago by julien

Revised Viktor's patch, adding 'project_name' to the paths

comment:3 Changed 7 years ago by julien

  • Triage Stage changed from Accepted to Ready for checkin

comment:4 Changed 7 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [8332]) Clarified a bit of the {% url %} documentation. Fixes #7714.

comment:5 Changed 4 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top