DateField/DateTimeField `in` lookup support

[Alexander Koshelev]

ORM doesn't support 'in' lookups for DateField/DateTimeField fields.

Example from test:

class Article(models.Model):
    headline = models.CharField(max_length=100)
    pub_date = models.DateTimeField()
    class Meta:
        ordering = ('-pub_date', 'headline')

    def __unicode__(self):
        return self.headline

Article.objects.filter(pub_date__in=[datetime(2005, 7, 26), datetime(2005, 7, 28)])

And it produces wrong SQL:

('SELECT `lookup_article`.`id`, `lookup_article`.`headline`, `lookup_article`.`pub_date` FROM `lookup_article` WHERE `lookup_article`.`pub_date`
 IN (%s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, 
%s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s,
 %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s)
ORDER BY `lookup_article`.`pub_date` DESC, `lookup_article`.`headline` ASC',
 (u'[', u'd', u'a', u't', u'e',u't', u'i', u'm', u'e', u'.', u'd', u'a', u't', u'e', u't', u'i', u'm', u'e',
 u'(', u'2', u'0', u'0', u'5', u',', u' ', u'7', u',', u' ', u'2', u'6', u',', u' ', u'0', u',', u' ', u'0', u')', u',', u' ', 
u'd', u'a', u't', u'e', u't', u'i', u'm', u'e', u'.', u'd', u'a', u't', u'e', u't', u'i', u'm', u'e', u'(', u'2', 
u'0', u'0', u'5', u',', u' ', u'7', u',', u' ', u'2', u'8', u',', u' ', u'0', u',', u' ', u'0', u')', u']'))

[Alexander Koshelev]

path

[Karen Tracey <kmtracey@…>]

#7448 already covers this, I believe.

[Alexander Koshelev]

My solution is better and has test case.

[Karen Tracey <kmtracey@…>]

And I pointed to your patch and noted it had a testcase over in #7448. There is only one problem here, we don't need multiple tickets for it. If you want to argue for your specific way of fixing the problem, please do so over in #7448.

[Alexander Koshelev]

Ok. Thanks.

[Malcolm Tredinnick]

(In [7883]) Fixed #7448 -- Convert "in" filters to pass in the correct values for datetimes
and similar complex objects.

Based on patches from cgrady and alexkosholev. Refs #7707.

[Jacob]

Milestone 1.0 deleted