Code

Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#7695 closed (fixed)

Admin doc model detail template should not escape help_text

Reported by: benspaulding Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Keywords: escape html
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

A model field’s help_text is deliberately not escaped when it is displayed in the admin (see #4991, [source:/django/trunk/docs/model-api.txt@5816#L627 model-api.txt]). The admin_doc [source:/django/branches/newforms-admin/django/contrib/admin/templates/admin_doc/model_detail.html model_detail.html] template should also follow this convention.

Attachments (1)

model_detail.diff (670 bytes) - added by benspaulding 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by benspaulding

comment:1 Changed 6 years ago by Simon Greenhill

  • milestone set to 1.0 beta
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 6 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [8137]) Fixed #7695 -- Modified template to trust help_text on a model field. Thanks to Ben Spaulding for the report.

comment:3 Changed 3 years ago by jacob

  • milestone 1.0 beta deleted

Milestone 1.0 beta deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.