Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#7657 closed (invalid)

newforms-admin: django/contrib/auth/decorators.py should be using wraps

Reported by: simon Owned by:
Component: contrib.auth Version: newforms-admin
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

http://code.djangoproject.com/browser/django/branches/newforms-admin/django/contrib/auth/decorators.py

wraps and update_wrapper are imported but not used. This is probably going to break things further down the line e.g. URL reversing which can get confused by decorators.

Change History (2)

comment:1 Changed 7 years ago by simon

  • Resolution set to invalid
  • Status changed from new to closed

On further inspection, the _CheckLogin class in that module appears to be using update_wrapper and doing the right thing. Closed as invalid.

comment:2 Changed 4 years ago by jacob

  • milestone 1.0 beta deleted

Milestone 1.0 beta deleted

Note: See TracTickets for help on using tickets.
Back to Top