Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#7654 closed (fixed)

Modifying upload handlers on the fly - accessing request.POST also makes it immutable

Reported by: Rozza Owned by: nobody
Component: Documentation Version: newforms-admin
Severity: Keywords: newforms admin file uploadhandler
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In the manual it warns accessing request.FILES will make the file uploaders immutable. However if you access request.POST like the @staff_member_required decorator does you can't then append or insert an upload handler in the view function.

As the parsing of the POST and FILES data is coupled - suggest updating the documentation to warn accessing request.POST has the same end effect as accessing request.FILES.

Attachments (2)

upload_handling.txt.patch (691 bytes) - added by Rozza 8 years ago.
Small documentation patch
file_uploads_tests.patch (2.1 KB) - added by Rozza 8 years ago.
Added Test case - which shows the behaviour

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Rozza

Attachment: upload_handling.txt.patch added

Small documentation patch

Changed 8 years ago by Rozza

Attachment: file_uploads_tests.patch added

Added Test case - which shows the behaviour

comment:1 Changed 8 years ago by Eric Holscher

milestone: 1.0
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 8 years ago by James Bennett

Resolution: fixed
Status: newclosed

(In [8758]) Fixed #7654: Documented the fact that file upload handlers must be modified before reading request.POST

comment:3 Changed 5 years ago by Jacob

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top