#7654 closed (fixed)
Modifying upload handlers on the fly - accessing request.POST also makes it immutable
| Reported by: | Rozza | Owned by: | nobody |
|---|---|---|---|
| Component: | Documentation | Version: | newforms-admin |
| Severity: | Keywords: | newforms admin file uploadhandler | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In the manual it warns accessing request.FILES will make the file uploaders immutable. However if you access request.POST like the @staff_member_required decorator does you can't then append or insert an upload handler in the view function.
As the parsing of the POST and FILES data is coupled - suggest updating the documentation to warn accessing request.POST has the same end effect as accessing request.FILES.
Attachments (2)
Change History (5)
by , 16 years ago
| Attachment: | upload_handling.txt.patch added |
|---|
by , 16 years ago
| Attachment: | file_uploads_tests.patch added |
|---|
Added Test case - which shows the behaviour
comment:1 by , 16 years ago
| milestone: | → 1.0 |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Small documentation patch