Code

Opened 6 years ago

Closed 6 years ago

#7620 closed (fixed)

Use super(..., cls).__new__ instead of type.__new__ in metaclass django.newforms.MediaDefiningClass

Reported by: Christian Tanzer <tanzer@…> Owned by: nobody
Component: Forms Version: newforms-admin
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

As discussed on django-developers@…, here is a patch for django.newforms.MediaDefiningClass.new to use super instead of type to chain up.

Attachments (1)

widgets.diff (685 bytes) - added by Christian Tanzer <tanzer@…> 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by Christian Tanzer <tanzer@…>

comment:1 Changed 6 years ago by Christian Tanzer <tanzer@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Version changed from SVN to newforms-admin

comment:2 Changed 6 years ago by brosner

  • Resolution set to fixed
  • Status changed from new to closed

(In [7834]) newforms-admin: Fixed #7620 -- Changed a hard-coded call to type.new to use super in MediaDefiningClass metaclass. Thanks Christian Tanzer.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.