#7575 closed (fixed)
Peruvian departments are now regions
Reported by: | Andres Riofrio | Owned by: | nobody |
---|---|---|---|
Component: | contrib.localflavor | Version: | dev |
Severity: | Keywords: | pe l10n | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Recently, I think in 2007, Peru switched over to regions. This affects django.contrib.localflavor.pe.PEDepartmentSelect, which should be renamed to PERegionSelect. Also, the Callao Region should be added.
(See http://en.wikipedia.org/wiki/Administrative_divisions_of_Peru.)
Another issue, although related to this change, is that the Province of Lima (which is separate from Lima Region) is not part of any Region. This is similar to the U.S., where Washington D.C. is independent from other states. The difference is that more than one third of Peru's population lives in the Lima and Callao Metropolitan Area.
The proposed solution is to create a PEDivisonSelect (and, subsequently, a USDivisionSelect), which include all top-level divisions of the countries. Note that, for example, USStateSelect includes Puerto Rico, which is not a state, but a commonwealth. (http://en.wikipedia.org/wiki/Puerto_Rico#Within_the_United_States). It would be included in USDivisionSelect.
Attachments (2)
Change History (7)
by , 16 years ago
Attachment: | django-peruvian-regions.patch added |
---|
comment:1 by , 16 years ago
Keywords: | pe l10n added |
---|---|
milestone: | → 1.0 beta |
Triage Stage: | Unreviewed → Ready for checkin |
comment:2 by , 16 years ago
Patch needs improvement: | set |
---|---|
Triage Stage: | Ready for checkin → Accepted |
I don't understand how a patch that cannot be applied can be marked as "ready for checkin". This patch patches a non-existent file. Could triagers please be careful when changing the ticket states.
Patch needs improvement so that it applies to trunk before it can go in.
comment:3 by , 16 years ago
Patch needs improvement: | unset |
---|---|
Triage Stage: | Accepted → Ready for checkin |
This should work correctly.
comment:4 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Changed Peruvian Departments to Regions and added Callao.