Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#7575 closed (fixed)

Peruvian departments are now regions

Reported by: andresj Owned by: nobody
Component: contrib.localflavor Version: master
Severity: Keywords: pe l10n
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Recently, I think in 2007, Peru switched over to regions. This affects django.contrib.localflavor.pe.PEDepartmentSelect, which should be renamed to PERegionSelect. Also, the Callao Region should be added.
(See http://en.wikipedia.org/wiki/Administrative_divisions_of_Peru.)

Another issue, although related to this change, is that the Province of Lima (which is separate from Lima Region) is not part of any Region. This is similar to the U.S., where Washington D.C. is independent from other states. The difference is that more than one third of Peru's population lives in the Lima and Callao Metropolitan Area.

The proposed solution is to create a PEDivisonSelect (and, subsequently, a USDivisionSelect), which include all top-level divisions of the countries. Note that, for example, USStateSelect includes Puerto Rico, which is not a state, but a commonwealth. (http://en.wikipedia.org/wiki/Puerto_Rico#Within_the_United_States). It would be included in USDivisionSelect.

Attachments (2)

django-peruvian-regions.patch (3.0 KB) - added by andresj 7 years ago.
Changed Peruvian Departments to Regions and added Callao.
7575.diff (3.2 KB) - added by programmerq 7 years ago.
Patch applies cleanly to trunk

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by andresj

Changed Peruvian Departments to Regions and added Callao.

comment:1 Changed 7 years ago by Simon Greenhill

  • Keywords pe l10n added
  • milestone set to 1.0 beta
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 7 years ago by mtredinnick

  • Patch needs improvement set
  • Triage Stage changed from Ready for checkin to Accepted

I don't understand how a patch that cannot be applied can be marked as "ready for checkin". This patch patches a non-existent file. Could triagers please be careful when changing the ticket states.

Patch needs improvement so that it applies to trunk before it can go in.

Changed 7 years ago by programmerq

Patch applies cleanly to trunk

comment:3 Changed 7 years ago by programmerq

  • Patch needs improvement unset
  • Triage Stage changed from Accepted to Ready for checkin

This should work correctly.

comment:4 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [8230]) Fixed #7575 -- Peru now has regions, not departments (changed at some pointi n
the last year or so). Thanks andresj and programmerq.

This is backwards incompatible if you're using the Peruvian localflavor.

comment:5 Changed 4 years ago by jacob

  • milestone 1.0 beta deleted

Milestone 1.0 beta deleted

Note: See TracTickets for help on using tickets.
Back to Top