#7568 closed (wontfix)
Pep8 Style Code In Newforms
| Reported by: | Steve Milner | Owned by: | nobody |
|---|---|---|---|
| Component: | Forms | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Running pep8 code checker against newforms yields a lot of output. I've attached a patch that helps start the move closer to pep8 (patch -p1 < 0001-started-to-move-newforms-closer-to-pep8-standards.diff).
Attachments (1)
Change History (3)
Changed 15 years ago by
| Attachment: | 0001-started-to-move-newforms-closer-to-pep8-standards.diff added |
|---|
comment:1 Changed 15 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
Thanks, but no thanks. A bunch of these changes are actually bad style (for example, splitting imports from a single model over multiple lines). Yes, there are a lot of lines in Django that are longer than 79 characters. Life's like that sometimes. It's not insurmountable and when we edit the code for other reasons, they'll sometimes be cleaned up.
It's more useful to have accurate annotation information on the lines of code so that we can see when they were last changed for a good reason (rather than just stylistic editing) and including this patch would remove that information from the "annotate" command in any version control system. That's a big minus when debugging.