Code

Opened 6 years ago

Closed 6 years ago

#7563 closed (wontfix)

A change in db\models\base.py is not compatible with the dumpscript command extension.

Reported by: stp2007 <stp2007@…> Owned by: nobody
Component: Uncategorized Version: master
Severity: Keywords: dumpscript command extension
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

A change in db\models\base.py is not compatible with the dumpscript command extension.

Revision 7642 of db\models\base.py at line 379 was:

if pk_val in seen_objs.setdefault(self.__class__, {}):
    return

Current version is:

if seen_objs.add(self.__class__, pk_val, self, parent, nullable):
    return

This causes dumpscript to generate a " 'dict' object has no attribute 'add'" error because it passes in an empty dict to _collect_sub_objects

Attachments (0)

Change History (1)

comment:1 Changed 6 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to wontfix
  • Status changed from new to closed

It seems to me that this is a problem with dumpscript, not with Django. The line of code you are referring to is an internal part of Django, and not part of documented API. If the change in [7642] breaks an external script, that's a pity, but it isn't really a problem with Django itself. This should be reported to whoever is maintaining dumpscript.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.