return None in sites.py doesn't work with decorators

[Michael Newman]

Simply, adding the cache to the login view in the new admin broke the way it handled persistent data. ​http://buildbot.djangoproject.com/newforms-admin%202.4%20sqlite/builds/237/step-test/0

[Michael Newman]

Simple patch that uses the request path to get the response from model_page instead

[Marc Garcia]

According to ticket organization defined in ​http://code.djangoproject.com/wiki/VersionOneRoadmap#how-you-can-help 1.0 alpha tickets should be just features in the Must have (​http://code.djangoproject.com/wiki/VersionOneRoadmap#must-have-features) list.

As bug, it should be fixed before 1.0 milestone.

[Brian Rosner]

This is broken functionality since [7737]. It needs to block the merge. Tagging as so and milestone for 1.0 alpha. I will have it fixed shortly.

[Simon Willison]

I fixed this in [7824] without realising there was a ticket for it. brosner: you should check that my fix is appropriate (the fix in the patch attached to this ticket may be a better option).

[Michael Newman]

A proof-of-concept patch using an exception to catch data that may fall through.

[Michael Newman]

Another way to fix this problem using refactored code, without a try and except. Still not the cleanest.

[Michael Newman]

Here are two patches which fix this problem. One is raising an exception from the view, that can be caught when there is Post Data that might be lost and the second reuses the root function with the self.root_url variable that is available to just return the root function. I prefer the later (Catching a manufactured exception is a little ... well...). Simon, your revision fixes the problem, but Brian and I decided that this needs to be fixed in the admin and that the views shouldn't be changed to handle the admin. Also, login is a view function, except that one time when it returns None and it becomes just another function.

[Brian Rosner]

What is the reason for moving delete_test_cookie and removing the is_active check?

[Michael Newman]

Updated based on brosner's comments

[Brian Rosner]

(In [7933]) newforms-admin: Fixed #7553 -- Reverted [7824] in favor of a better fix in #7553. The never_cache decorator is no longer special casing None. Thanks Michael Newman for the patch.

[Jacob]

Milestone 1.0 alpha deleted