Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#7550 closed (worksforme)

Django doesn't work when called from a subdirectory using (Fast)CGI

Reported by: Andreas Kloeckner <inform@…> Owned by: nobody
Component: HTTP handling Version: master
Severity: Keywords:
Cc: inform@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

If a CGI calls django with an empty PATH_INFO (as may happen if the user only gives the script name, but nothing following it), Django dies with the following, opaque error message:

Traceback:
File "/sparc_soft/www.dam/htdocs/scicomp/pool/lib/python2.5/site-packages/django/core/handlers/base.py" 
in get_response
  73.             callback, callback_args, callback_kwargs = 
resolver.resolve(request.path)

Exception Type: TypeError at 
Exception Value: unpack non-sequence

This is the first problem, and it's due to the fact that if the request path does not match the resolver's self.regex, RegexURLResolver.resolve will simply return None, and the above tuple unpacking fails.

The second problem is that a few lines above the line in the traceback, the RegexURLResolver gets initialized with a "/" regex, and there's no user-facing way of changing that.

I fixed it for myself by simply feeding the resolver '/' if the path is empty. I'd prefer if there was a workable solution in Django by default.

Change History (7)

comment:1 Changed 7 years ago by Andreas Kloeckner <inform@…>

  • Cc inform@… added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 7 years ago by Simon Greenhill

  • milestone set to 1.0 alpha
  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 7 years ago by garcia_marc

  • milestone changed from 1.0 alpha to 1.0

According to ticket organization defined in http://code.djangoproject.com/wiki/VersionOneRoadmap#how-you-can-help 1.0 alpha tickets should be just features in the Must have (http://code.djangoproject.com/wiki/VersionOneRoadmap#must-have-features) list.

As bug, it should be fixed before 1.0 milestone.

comment:4 Changed 7 years ago by Andreas Kloeckner <inform@…>

  • Summary changed from Django doesn't work when called from a subdirectory (Fast)CGI to Django doesn't work when called from a subdirectory using (Fast)CGI

On a related note, the admin login form, when run from a subdirectory, redirects to /admin, ignoring any prefixes it may have been given. Likewise, the admin logout link points to /admin/logout, even if the real page is at /prefix/admin/logout.

comment:5 Changed 7 years ago by astoneman

  • Component changed from Uncategorized to HTTP handling

comment:6 Changed 7 years ago by mtrichardson

  • Resolution set to worksforme
  • Status changed from new to closed

comment:7 Changed 4 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top