urlize changing link text as well as url
|Reported by:||devin||Owned by:||devin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
>>> urlize('google.com') u'<a href="http://google.com">http://google.com</a>'
Instead of the pre- behavior of:
>>> urlize('google.com') u'<a href="http://google.com">google.com</a>'
Tests weren't written until , so this wasn't caught. But it popped up on our internal tests here at Disqus.
Since urlize is intended just to convert text to clickable links, not change what the text says, this is undesirable. This is mostly used for user generated content, and I feel it's wrong to be changing what the user typed.
I've attached a patch that fixes that problem. We need to keep a url target and a link text separate. Besides, I've cleaned up the function a bit as it got largely unreadable after  and updated the docstring to include mention of autoescape and the fact that this function now converts urls ending in .org, .net and .com. As well as updating the tests included in  to match this expected functionality.