Opened 19 years ago

Closed 19 years ago

Last modified 18 years ago

#753 closed defect (fixed)

ValidationError & CriticalValidationError raise assertion errors since translation update

Reported by: django@… Owned by: hugo
Component: Validators Version:
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


ValidationError and CriticalValidationError apply the following assertion to error message text:

assert isinstance(message, basestring), ("%s should be a string" % repr(message))

This causes AssertionErrors for messages wrapped with gettext_lazy()

Change History (5)

comment:1 by django@…, 19 years ago

Resolution: fixed
Status: newclosed

Somewhere along the way this one got fixed.

comment:2 by django@…, 19 years ago

Resolution: fixed
Status: closedreopened

Sorry, I lie: This one is still a problem for the default validation error messages wrapped in gettext_lazy.

comment:3 by hugo, 19 years ago

Owner: changed from Adrian Holovaty to hugo
Status: reopenednew

comment:4 by hugo, 19 years ago

Status: newassigned

comment:5 by hugo, 19 years ago

Resolution: fixed
Status: assignedclosed

(In [1328]) fixes #753 - ValidationError and CriticalValidationError now accept both strings and promises from gettext_lazy

Note: See TracTickets for help on using tickets.
Back to Top