Opened 8 years ago

Closed 7 years ago

#7529 closed (fixed)

Debug 500 Page Shows POST, GET, and COOKIES but not FILES

Reported by: Alex Gaynor Owned by: Alex Gaynor
Component: Core (Other) Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

It would be nice if it showed them.

Attachments (3)

files.diff (901 bytes) - added by Alex Gaynor 8 years ago.
Now it shows them just like POST, etc..
debug-files.diff (2.6 KB) - added by Alex Gaynor 7 years ago.
debug-files.2.diff (3.5 KB) - added by Alex Gaynor 7 years ago.

Download all attachments as: .zip

Change History (16)

Changed 8 years ago by Alex Gaynor

Attachment: files.diff added

Now it shows them just like POST, etc..

comment:1 Changed 8 years ago by Alex Gaynor

Has patch: set
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

comment:2 Changed 8 years ago by anonymous

Component: UncategorizedMetasystem
Triage Stage: UnreviewedDesign decision needed

comment:3 Changed 8 years ago by Bastian Kleineidam <calvin@…>

Patch needs improvement: set

The patch prints out full file contents in the debug page. This will be unpleasant with big files.

I suggest limiting the amount of printed file data to the first 200 bytes or so, and to replace binary characters with hexadecimal values.

comment:4 Changed 8 years ago by Malcolm Tredinnick

Triage Stage: Design decision neededAccepted

Files are huge amounts of data. A patch to show the number of uploaded files would be reasonable, but we shouldn't be showing their contents (even the first 200 bytes is really pretty useless most of the time). It's just too much opaque information. If somebody wants more information, they can do their own 500 handling without a lot of trouble (or put debugging prints into their code based on the exception traceback).

comment:5 Changed 8 years ago by Alex Gaynor

To my understanding the unicode method on the file objects should be printing out the filename, which is acceptable to print out.

comment:6 Changed 8 years ago by Michael Radziej

Keywords: 1.0-unsure added

comment:7 Changed 8 years ago by Alex Gaynor

Small note: I have tested this post-2070, so it does indeed print out the file names.

comment:9 Changed 8 years ago by Julian Bez

milestone: 1.0 maybe

comment:10 Changed 8 years ago by Jacob

Component: MetasystemCore framework
Keywords: 1.0-unsure removed
milestone: 1.0 maybepost-1.0

comment:11 Changed 8 years ago by Alex Gaynor

Owner: changed from nobody to Alex Gaynor

comment:12 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

Changed 7 years ago by Alex Gaynor

Attachment: debug-files.diff added

Changed 7 years ago by Alex Gaynor

Attachment: debug-files.2.diff added

comment:13 Changed 7 years ago by Alex Gaynor

Resolution: fixed
Status: newclosed

Fixed in r10271

Note: See TracTickets for help on using tickets.
Back to Top