Opened 7 years ago

Closed 18 months ago

#7425 closed Bug (duplicate)

change_form.html bodyclass block doesn't inherit

Reported by: wiremine@… Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

contrib/admin/templates/admin/change_form.html's bodyclass block doesn't inherit from superclasses. This caused me some problems integrating YUI's editor into a admin textarea. The YUI editor requires the body element's class to be 'yui-skin-sam' I'm setting this in a customized admin/base_site.html file, but it's not getting included. The attached patch adds {{block.super}} to the block to correct this.

Attachments (1)

change_form.patch (704 bytes) - added by wiremine@… 7 years ago.
change_form.html patch to correctly inherit body class values from parent templates

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by wiremine@…

change_form.html patch to correctly inherit body class values from parent templates

comment:1 Changed 7 years ago by ericholscher

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 7 years ago by Piotr Lewandowski <django@…>

  • Component changed from Uncategorized to Admin interface

comment:3 Changed 4 years ago by mk

  • Needs tests set
  • Patch needs improvement set

This patch does does not contain any tests. Furthermore, other admin templates (change_list.html, user/change_password.html etc) do not insert block.super either.

comment:4 Changed 4 years ago by lukeplant

  • Severity set to Normal
  • Type set to Bug

comment:5 Changed 4 years ago by anonymous

  • Easy pickings unset

What would a reasonable set of tests look like in this case?

comment:6 Changed 3 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:7 Changed 18 months ago by claudep

  • Resolution set to duplicate
  • Status changed from new to closed

#21371 seems to contain a more exhaustive patch.

Note: See TracTickets for help on using tickets.
Back to Top