Opened 16 years ago

Closed 11 years ago

#7425 closed Bug (duplicate)

change_form.html bodyclass block doesn't inherit

Reported by: wiremine@… Owned by: nobody
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

contrib/admin/templates/admin/change_form.html's bodyclass block doesn't inherit from superclasses. This caused me some problems integrating YUI's editor into a admin textarea. The YUI editor requires the body element's class to be 'yui-skin-sam' I'm setting this in a customized admin/base_site.html file, but it's not getting included. The attached patch adds {{block.super}} to the block to correct this.

Attachments (1)

change_form.patch​ (704 bytes ) - added by wiremine@… 16 years ago.
change_form.html patch to correctly inherit body class values from parent templates

Download all attachments as: .zip

Change History (8)

by wiremine@…, 16 years ago

Attachment: change_form.patch​ added

change_form.html patch to correctly inherit body class values from parent templates

comment:1 by Eric Holscher, 16 years ago

Has patch: set
Triage Stage: Unreviewed → Accepted

comment:2 by Piotr Lewandowski <django@…>, 16 years ago

Component: Uncategorized → Admin interface

comment:3 by Matthias Kestenholz, 14 years ago

Needs tests: set
Patch needs improvement: set

This patch does does not contain any tests. Furthermore, other admin templates (change_list.html, user/change_password.html etc) do not insert block.super either.

comment:4 by Luke Plant, 14 years ago

Severity: → Normal
Type: → Bug

comment:5 by anonymous, 13 years ago

Easy pickings: unset

What would a reasonable set of tests look like in this case?

comment:6 by Aymeric Augustin, 13 years ago

UI/UX: unset

Change UI/UX from NULL to False.

comment:7 by Claude Paroz, 11 years ago

Resolution: → duplicate
Status: new → closed

#21371 seems to contain a more exhaustive patch.

Note: See TracTickets for help on using tickets.
Back to Top