Opened 16 years ago

Closed 16 years ago

#7422 closed (invalid)

for tag missing in CheckboxSelectMultiple

Reported by: Adrian Ribao <aribao@…> Owned by: nobody
Component: Forms Version: dev
Severity: Keywords: for tag missing Checkbox
Cc: aribao@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

My site didn't pass AAA conformity level of accesibility so I changed one line of the widget to make it work.

It's a very simple patch and make the forms pass the AAA.

Attachments (3)

widgets.py.diff (732 bytes ) - added by Adrian Ribao <aribao@…> 16 years ago.
Diff file for widgets.py
widgets.py.2.diff (806 bytes ) - added by Adrian Ribao <aribao@…> 16 years ago.
New patch for widgets.py
forms.py.diff (810 bytes ) - added by Adrian Ribao <aribao@…> 16 years ago.
Patch for the unit test

Download all attachments as: .zip

Change History (9)

by Adrian Ribao <aribao@…>, 16 years ago

Attachment: widgets.py.diff added

Diff file for widgets.py

comment:1 by mrts, 16 years ago

Triage Stage: UnreviewedReady for checkin

Simple fix that increases correctness, marking as ready for checkin.

comment:2 by Matt McClanahan, 16 years ago

Patch needs improvement: set
Triage Stage: Ready for checkinAccepted

Please don't mark tickets ready for checkin without verifying the patch works. This patch fails unit tests.

comment:3 by Adrian Ribao <aribao@…>, 16 years ago

I have not much experience with testing, can you please tell me how can I see the error in the unittest please?

Thank you.

in reply to:  3 comment:4 by Ramiro Morales, 16 years ago

Replying to Adrian Ribao <aribao@gmail.com>:

I have not much experience with testing, can you please tell me how can I see the error in the unittest please?

Thank you.

http://www.djangoproject.com/documentation/contributing/#running-the-unit-tests

by Adrian Ribao <aribao@…>, 16 years ago

Attachment: widgets.py.2.diff added

New patch for widgets.py

by Adrian Ribao <aribao@…>, 16 years ago

Attachment: forms.py.diff added

Patch for the unit test

comment:5 by Adrian Ribao <aribao@…>, 16 years ago

Everything ok with this patches now?

comment:6 by Adrian Ribao <aribao@…>, 16 years ago

Resolution: invalid
Status: newclosed

After a discussion in the IRC, I realized the problem here is the validator and not Django.

Note: See TracTickets for help on using tickets.
Back to Top