Code

Opened 6 years ago

Closed 6 years ago

#7422 closed (invalid)

for tag missing in CheckboxSelectMultiple

Reported by: Adrian Ribao <aribao@…> Owned by: nobody
Component: Forms Version: master
Severity: Keywords: for tag missing Checkbox
Cc: aribao@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

My site didn't pass AAA conformity level of accesibility so I changed one line of the widget to make it work.

It's a very simple patch and make the forms pass the AAA.

Attachments (3)

widgets.py.diff (732 bytes) - added by Adrian Ribao <aribao@…> 6 years ago.
Diff file for widgets.py
widgets.py.2.diff (806 bytes) - added by Adrian Ribao <aribao@…> 6 years ago.
New patch for widgets.py
forms.py.diff (810 bytes) - added by Adrian Ribao <aribao@…> 6 years ago.
Patch for the unit test

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by Adrian Ribao <aribao@…>

Diff file for widgets.py

comment:1 Changed 6 years ago by mrts

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

Simple fix that increases correctness, marking as ready for checkin.

comment:2 Changed 6 years ago by mattmcc

  • Patch needs improvement set
  • Triage Stage changed from Ready for checkin to Accepted

Please don't mark tickets ready for checkin without verifying the patch works. This patch fails unit tests.

comment:3 follow-up: Changed 6 years ago by Adrian Ribao <aribao@…>

I have not much experience with testing, can you please tell me how can I see the error in the unittest please?

Thank you.

comment:4 in reply to: ↑ 3 Changed 6 years ago by ramiro

Replying to Adrian Ribao <aribao@gmail.com>:

I have not much experience with testing, can you please tell me how can I see the error in the unittest please?

Thank you.

http://www.djangoproject.com/documentation/contributing/#running-the-unit-tests

Changed 6 years ago by Adrian Ribao <aribao@…>

New patch for widgets.py

Changed 6 years ago by Adrian Ribao <aribao@…>

Patch for the unit test

comment:5 Changed 6 years ago by Adrian Ribao <aribao@…>

Everything ok with this patches now?

comment:6 Changed 6 years ago by Adrian Ribao <aribao@…>

  • Resolution set to invalid
  • Status changed from new to closed

After a discussion in the IRC, I realized the problem here is the validator and not Django.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.