Opened 8 years ago

Closed 8 years ago

#7422 closed (invalid)

for tag missing in CheckboxSelectMultiple

Reported by: Adrian Ribao <aribao@…> Owned by: nobody
Component: Forms Version: master
Severity: Keywords: for tag missing Checkbox
Cc: aribao@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

My site didn't pass AAA conformity level of accesibility so I changed one line of the widget to make it work.

It's a very simple patch and make the forms pass the AAA.

Attachments (3)

widgets.py.diff (732 bytes) - added by Adrian Ribao <aribao@…> 8 years ago.
Diff file for widgets.py
widgets.py.2.diff (806 bytes) - added by Adrian Ribao <aribao@…> 8 years ago.
New patch for widgets.py
forms.py.diff (810 bytes) - added by Adrian Ribao <aribao@…> 8 years ago.
Patch for the unit test

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by Adrian Ribao <aribao@…>

Attachment: widgets.py.diff added

Diff file for widgets.py

comment:1 Changed 8 years ago by mrts

Triage Stage: UnreviewedReady for checkin

Simple fix that increases correctness, marking as ready for checkin.

comment:2 Changed 8 years ago by Matt McClanahan

Patch needs improvement: set
Triage Stage: Ready for checkinAccepted

Please don't mark tickets ready for checkin without verifying the patch works. This patch fails unit tests.

comment:3 Changed 8 years ago by Adrian Ribao <aribao@…>

I have not much experience with testing, can you please tell me how can I see the error in the unittest please?

Thank you.

comment:4 in reply to:  3 Changed 8 years ago by Ramiro Morales

Replying to Adrian Ribao <aribao@gmail.com>:

I have not much experience with testing, can you please tell me how can I see the error in the unittest please?

Thank you.

http://www.djangoproject.com/documentation/contributing/#running-the-unit-tests

Changed 8 years ago by Adrian Ribao <aribao@…>

Attachment: widgets.py.2.diff added

New patch for widgets.py

Changed 8 years ago by Adrian Ribao <aribao@…>

Attachment: forms.py.diff added

Patch for the unit test

comment:5 Changed 8 years ago by Adrian Ribao <aribao@…>

Everything ok with this patches now?

comment:6 Changed 8 years ago by Adrian Ribao <aribao@…>

Resolution: invalid
Status: newclosed

After a discussion in the IRC, I realized the problem here is the validator and not Django.

Note: See TracTickets for help on using tickets.
Back to Top