Opened 16 years ago
Closed 16 years ago
#7422 closed (invalid)
for tag missing in CheckboxSelectMultiple
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | Forms | Version: | dev |
| Severity: | Keywords: | for tag missing Checkbox | |
| Cc: | aribao@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
My site didn't pass AAA conformity level of accesibility so I changed one line of the widget to make it work.
It's a very simple patch and make the forms pass the AAA.
Attachments (3)
Change History (9)
by , 16 years ago
| Attachment: | widgets.py.diff added |
|---|
comment:1 by , 16 years ago
| Triage Stage: | Unreviewed → Ready for checkin |
|---|
Simple fix that increases correctness, marking as ready for checkin.
comment:2 by , 16 years ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Ready for checkin → Accepted |
Please don't mark tickets ready for checkin without verifying the patch works. This patch fails unit tests.
follow-up: 4 comment:3 by , 16 years ago
I have not much experience with testing, can you please tell me how can I see the error in the unittest please?
Thank you.
comment:4 by , 16 years ago
Replying to Adrian Ribao <aribao@gmail.com>:
I have not much experience with testing, can you please tell me how can I see the error in the unittest please?
Thank you.
http://www.djangoproject.com/documentation/contributing/#running-the-unit-tests
comment:6 by , 16 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
After a discussion in the IRC, I realized the problem here is the validator and not Django.
Diff file for widgets.py