#742 closed defect (fixed)
history raises error in datetime while using non english language
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | Core (Other) | Version: | 1.0 |
| Severity: | major | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
I slightly polished dateformat.py, which was the reason of rasing error in Admin/history, when using different locale settings.
Patch:
Index: C:/Python24/Lib/site-packages/django/utils/dateformat.py
===================================================================
--- C:/Python24/Lib/site-packages/django/utils/dateformat.py (revision 1092)
+++ C:/Python24/Lib/site-packages/django/utils/dateformat.py (working copy)
@@ -14,6 +14,7 @@
from django.utils.dates import MONTHS, MONTHS_AP, WEEKDAYS
from django.utils.tzinfo import LocalTimezone
from calendar import isleap
+from calendar import monthrange
import re, time
re_formatchars = re.compile(r'(?<!\\)([aABdDfFgGhHiIjlLmMnNOPrsStTUwWyYzZ])')
@@ -124,10 +125,6 @@
def I(self):
"'1' if Daylight Savings Time, '0' otherwise."
- raise NotImplementedError
-
- def I(self):
- "'1' if Daylight Savings Time, '0' otherwise."
if self.timezone.dst(self.data):
return '1'
else:
@@ -185,7 +182,8 @@
def t(self):
"Number of days in the given month; i.e. '28' to '31'"
- raise NotImplementedError
+ num = monthrange(self.data.year, self.data.month)[1]
+ return '%02d' % num
def T(self):
"Time zone of this machine; e.g. 'EST' or 'MDT'"
Change History (4)
comment:1 by , 20 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:2 by , 20 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Hi, this issue is not working with languages like es, es-es, es-mx, etc... The output is something like this: "LunAMCESTE_171CEST03_CEST1AbrE_Abril1146273358FalseFalse" instead of "24 de Abril, 2006, 3:15 a.m.". I´ve checked my dateformat.py and it is the same like yours.
Thank You Very Much.
comment:3 by , 19 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Closing this ticket. Please reopen with more information if it's still a problem.
Note:
See TracTickets
for help on using tickets.
(In [1116]) Fixed #742 -- Implemented 't' dateformat. Thanks, radek.