Opened 7 years ago

Closed 10 months ago

Last modified 7 months ago

#7361 closed New feature (fixed)

Add back button to admin delete page

Reported by: simon Owned by: barbuza
Component: contrib.admin Version: master
Severity: Normal Keywords: usability nfa-someday feature
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: yes

Description

It's just been pointed out to me that when you hit "Delete" in the Django admin you get a "Are you sure?" page with only one button: "Yes, I'm sure". There's no alternative "no, get me out of here" option.

Apparently some people may find this upsetting :)

This problem is particularly important for delete pages with lots of related items and hence a massive list of things that will be deleted. The huge list makes the page enormously more frightening, and by the time the user has scrolled down to the button at the bottom they can no longer see the top navigation with safe links to other parts of the interface.

Attachments (2)

delete_confirmation.1.diff (617 bytes) - added by barbuza 7 years ago.
7361.admin-cancel-delete.diff (1.9 KB) - added by julien 4 years ago.
Cancel action as a link

Download all attachments as: .zip

Change History (17)

comment:1 Changed 7 years ago by Karen Tracey <kmtracey@…>

  • Keywords nfa-someday added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

There's always the back button. Behavior is no different from trunk, so this should not block merge.

comment:2 Changed 7 years ago by edgarsj

  • Keywords feature added
  • Triage Stage changed from Unreviewed to Design decision needed

comment:3 Changed 7 years ago by barbuza

  • Owner changed from nobody to barbuza
  • Status changed from new to assigned

Changed 7 years ago by barbuza

comment:4 Changed 7 years ago by barbuza

  • Has patch set

comment:5 Changed 4 years ago by lukeplant

  • Severity set to Normal
  • Type set to New feature

comment:6 Changed 4 years ago by julien

  • UI/UX set

Changed 4 years ago by julien

Cancel action as a link

comment:7 Changed 4 years ago by julien

  • Easy pickings unset
  • Needs tests set
  • Patch needs improvement set

The attached patch suggests having the cancel action as a link instead of a button, since its purpose effectively is to navigate back to where you were. The behaviour would probably also need to be the same as clicking the browser's back button, that is, the link's href would be something like "javascript:history.back()" -- although there could be an issue if javascript was turned off. Patch still needs some tweaking and some tests.

comment:8 Changed 4 years ago by carljm

  • Triage Stage changed from Design decision needed to Accepted

comment:9 Changed 15 months ago by jli

I would like to give this ticket some love, any advice on how to make it go forward ?

comment:10 Changed 14 months ago by timo

@jli, improve the patch as noted in the comment above.

comment:11 Changed 12 months ago by slurms

  • Needs tests unset
  • Patch needs improvement unset

comment:12 Changed 12 months ago by timo

  • Patch needs improvement set
  • Summary changed from newforms-admin delete page gives you no way out! to Add back button to admin delete page
  • Version changed from newforms-admin to master

Left comments for improvement on PR.

comment:13 Changed 10 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In f5cfd09c257e5a4ed6d01d32505c48b02e3860d5:

Fixed #7361 -- Added cancel link to admin delete views.

comment:14 Changed 8 months ago by Tim Graham <timograham@…>

In 43fcf3505eb22228f551ab03122f99b3d40f38ed:

Fixed admin_views test from refs #7361 (name was too long).

comment:15 Changed 7 months ago by Tim Graham <timograham@…>

In b8abfe141be17f20079f55b921dcaf7abe116c4b:

Fixed #24101 -- Fixed flaky admin_views selenium tests; refs #7361.

Note: See TracTickets for help on using tickets.
Back to Top