Opened 16 years ago

Closed 10 years ago

Last modified 10 years ago

#7361 closed New feature (fixed)

Add back button to admin delete page

Reported by: simon Owned by: barbuza
Component: contrib.admin Version: dev
Severity: Normal Keywords: usability nfa-someday feature
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: yes

Description

It's just been pointed out to me that when you hit "Delete" in the Django admin you get a "Are you sure?" page with only one button: "Yes, I'm sure". There's no alternative "no, get me out of here" option.

Apparently some people may find this upsetting :)

This problem is particularly important for delete pages with lots of related items and hence a massive list of things that will be deleted. The huge list makes the page enormously more frightening, and by the time the user has scrolled down to the button at the bottom they can no longer see the top navigation with safe links to other parts of the interface.

Attachments (2)

delete_confirmation.1.diff​ (617 bytes ) - added by barbuza 16 years ago.
7361.admin-cancel-delete.diff​ (1.9 KB ) - added by Julien Phalip 13 years ago.
Cancel action as a link

Download all attachments as: .zip

Change History (17)

comment:1 by Karen Tracey <kmtracey@…>, 16 years ago

Keywords: nfa-someday added

There's always the back button. Behavior is no different from trunk, so this should not block merge.

comment:2 by edgarsj, 16 years ago

Keywords: feature added
Triage Stage: Unreviewed → Design decision needed

comment:3 by barbuza, 16 years ago

Owner: changed from nobody to barbuza
Status: new → assigned

by barbuza, 16 years ago

Attachment: delete_confirmation.1.diff​ added

comment:4 by barbuza, 16 years ago

Has patch: set

comment:5 by Luke Plant, 14 years ago

Severity: → Normal
Type: → New feature

comment:6 by Julien Phalip, 13 years ago

UI/UX: set

by Julien Phalip, 13 years ago

Attachment: 7361.admin-cancel-delete.diff​ added

Cancel action as a link

comment:7 by Julien Phalip, 13 years ago

Easy pickings: unset
Needs tests: set
Patch needs improvement: set

The attached patch suggests having the cancel action as a link instead of a button, since its purpose effectively is to navigate back to where you were. The behaviour would probably also need to be the same as clicking the browser's back button, that is, the link's href would be something like "javascript:history.back()" -- although there could be an issue if javascript was turned off. Patch still needs some tweaking and some tests.

comment:8 by Carl Meyer, 13 years ago

Triage Stage: Design decision needed → Accepted

comment:9 by Jonathan Liuti, 10 years ago

I would like to give this ticket some love, any advice on how to make it go forward ?

comment:10 by Tim Graham, 10 years ago

@jli, improve the patch as noted in the comment above.

comment:11 by Nick Sandford, 10 years ago

Needs tests: unset
Patch needs improvement: unset

PR here: ​https://github.com/django/django/pull/2993

comment:12 by Tim Graham, 10 years ago

Patch needs improvement: set
Summary: newforms-admin delete page gives you no way out! → Add back button to admin delete page
Version: newforms-admin → master

Left comments for improvement on PR.

comment:13 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: assigned → closed

In f5cfd09c257e5a4ed6d01d32505c48b02e3860d5:

Fixed #7361 -- Added cancel link to admin delete views.

comment:14 by Tim Graham <timograham@…>, 10 years ago

In 43fcf3505eb22228f551ab03122f99b3d40f38ed:

Fixed admin_views test from refs #7361 (name was too long).

comment:15 by Tim Graham <timograham@…>, 10 years ago

In b8abfe141be17f20079f55b921dcaf7abe116c4b:

Fixed #24101 -- Fixed flaky admin_views selenium tests; refs #7361.

Note: See TracTickets for help on using tickets.
Back to Top