#7272 closed (fixed)
newforms-admin admin UI has incorrect button defaults
Reported by: | sil | Owned by: | Jacob |
---|---|---|---|
Component: | contrib.admin | Version: | newforms-admin |
Severity: | Keywords: | nfa-someday sprint-ep2008 checkin | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
In the admin UI, there are three save buttons -- Save, Save and continue editing, Save and add another. "Save" is marked as the default button (it is blue). However, hitting Enter in any textbox on the admin page activates the *actual* default button, which is the first one on the form, which is "Save and add another". Therefore, there are the following issues:
- the Save button indicates that it's the default, but it isn't
- the default is actually "Save and add another". This is confusing because hitting Enter in a field, thus performing "save and add another", will actually take you to a new fresh edit form for the model you're editing. Other than the (small) message saying "The <x> was added successfully", this looks exactly like the user hit Enter and it removed all their entered data from the form!
Proposed fix: make the default button be "Save and continue editing": put this button first in the HTML of the form, mark it as default (colour it blue), and order the buttons as required visually with CSS.
Attachments (2)
Change History (10)
by , 16 years ago
Attachment: | django-buttons.png added |
---|
comment:1 by , 16 years ago
Keywords: | nfa-someday added |
---|---|
Triage Stage: | Unreviewed → Design decision needed |
Version: | SVN → newforms-admin |
Confirmed still an issue on newforms-admin. While "SAVE" has the appearance of being the default action, in fact when you just hit enter from a text field the action taken is "Save and add another". Not sure what the right fix is but the way it is now is definitely confusing to a user, so something should be done.
by , 16 years ago
Attachment: | ticket7272-r7871.1.diff added |
---|
Moved the submit button to the front of the other and added float directive (compatible with rtl languages)
comment:2 by , 16 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:3 by , 16 years ago
Keywords: | sprint-ep2008 checkin added |
---|
comment:4 by , 16 years ago
Has patch: | set |
---|
comment:5 by , 16 years ago
milestone: | → 1.0 |
---|
comment:6 by , 16 years ago
Owner: | changed from | to
---|---|
Status: | assigned → new |
Triage Stage: | Design decision needed → Ready for checkin |
comment:7 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [8501]) Tweaked the Admin add/change page so that "save" is still the highlighted
too look like the default button and it actually operates as the defaut
(previously "save and add another" was the default action, which confused
people if you hit the save button and it looked like your work was eaten by a
grue).
Fixed #7272. Patch from Jannis Leidel.
screenshot of three buttons showing "Save" as default, incorrectly