Opened 7 years ago

Closed 7 years ago

Last modified 3 years ago

#7272 closed (fixed)

newforms-admin admin UI has incorrect button defaults

Reported by: sil Owned by: jacob
Component: contrib.admin Version: newforms-admin
Severity: Keywords: nfa-someday sprint-ep2008 checkin
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In the admin UI, there are three save buttons -- Save, Save and continue editing, Save and add another. "Save" is marked as the default button (it is blue). However, hitting Enter in any textbox on the admin page activates the *actual* default button, which is the first one on the form, which is "Save and add another". Therefore, there are the following issues:

  1. the Save button indicates that it's the default, but it isn't
  1. the default is actually "Save and add another". This is confusing because hitting Enter in a field, thus performing "save and add another", will actually take you to a new fresh edit form for the model you're editing. Other than the (small) message saying "The <x> was added successfully", this looks exactly like the user hit Enter and it removed all their entered data from the form!

Proposed fix: make the default button be "Save and continue editing": put this button first in the HTML of the form, mark it as default (colour it blue), and order the buttons as required visually with CSS.

Attachments (2)

django-buttons.png (3.4 KB) - added by sil 7 years ago.
screenshot of three buttons showing "Save" as default, incorrectly
ticket7272-r7871.1.diff (2.8 KB) - added by jezdez 7 years ago.
Moved the submit button to the front of the other and added float directive (compatible with rtl languages)

Download all attachments as: .zip

Change History (10)

Changed 7 years ago by sil

screenshot of three buttons showing "Save" as default, incorrectly

comment:1 Changed 7 years ago by Karen Tracey <kmtracey@…>

  • Keywords nfa-someday added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed
  • Version changed from SVN to newforms-admin

Confirmed still an issue on newforms-admin. While "SAVE" has the appearance of being the default action, in fact when you just hit enter from a text field the action taken is "Save and add another". Not sure what the right fix is but the way it is now is definitely confusing to a user, so something should be done.

Changed 7 years ago by jezdez

Moved the submit button to the front of the other and added float directive (compatible with rtl languages)

comment:2 Changed 7 years ago by jezdez

  • Owner changed from nobody to jezdez
  • Status changed from new to assigned

comment:3 Changed 7 years ago by jezdez

  • Keywords sprint-ep2008 checkin added

comment:4 Changed 7 years ago by jezdez

  • Has patch set

comment:5 Changed 7 years ago by jezdez

  • milestone set to 1.0

comment:6 Changed 7 years ago by jacob

  • Owner changed from jezdez to jacob
  • Status changed from assigned to new
  • Triage Stage changed from Design decision needed to Ready for checkin

comment:7 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [8501]) Tweaked the Admin add/change page so that "save" is still the highlighted
too look like the default button and it actually operates as the defaut
(previously "save and add another" was the default action, which confused
people if you hit the save button and it looked like your work was eaten by a
grue).

Fixed #7272. Patch from Jannis Leidel.

comment:8 Changed 3 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top