Opened 16 years ago

Closed 16 years ago

Last modified 12 years ago

#7250 closed (fixed)

Internal data shown when uploading a ImageField fails

Reported by: Marc Garcia Owned by: Marc Garcia
Component: contrib.admin Version: newforms-admin
Severity: Keywords: nfa nfa-someday
Cc: marc.garcia@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Ramiro Morales)

In newforms-admin, when uploading a file that isn't an image to a ImageField field, file internal data is display for "Currently". Shown data is something like {'content': '', 'content-type': 'text/plain', 'filename': 'test.txt'}

Same will happen if anything else fails when uploading to a FileField or a ImageField.

Attachments (1)

7250.diff (545 bytes ) - added by Marc Garcia 16 years ago.
Patch that correct the issue

Download all attachments as: .zip

Change History (10)

comment:1 by Karen Tracey <kmtracey@…>, 16 years ago

Keywords: nfa-someday added

Not pretty but not a deal-breaker for merge to trunk.

by Marc Garcia, 16 years ago

Attachment: 7250.diff added

Patch that correct the issue

comment:2 by Marc Garcia, 16 years ago

Has patch: set
Needs tests: set

Cannot add tests with the patch because the difficulty in testing with files on the python shell.

I've tested the patch in the admin, but testing on forms and with ModelForm is still required.

This patch isn't supposed to modify the behavior of file deletion, but it would be recommended to check it.

comment:3 by Marc Garcia, 16 years ago

milestone: 1.0

comment:4 by Ramiro Morales, 16 years ago

Description: modified (diff)

comment:5 by Marty Alchin, 16 years ago

Keywords: fs-rf removed

The filestorage refactor isn't dealing with the forms side of things. While this probably does need to be addressed, it's not part of fs-rf, so I'm removing the keyword.

comment:6 by Marc Garcia, 16 years ago

Cc: marc.garcia@… added; Marc Garcia removed
Owner: changed from nobody to Marc Garcia

comment:7 by Eric Holscher, 16 years ago

Triage Stage: UnreviewedAccepted

comment:8 by Brian Rosner, 16 years ago

Resolution: fixed
Status: newclosed

(In [8277]) Fixed #7250 -- Don't show internal data of a FileField in the admin when the form does not validate. This also alternatively fixes a recent problem since [8244] when the form is not valid. Thanks Marc Garcia for the initial ticket.

comment:9 by Jacob, 12 years ago

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top