Opened 17 years ago

Closed 17 years ago

Last modified 14 years ago

#7230 closed (fixed)

No save_m2m method on BaseModelFormSet or BaseInlineFormSet

Reported by: brooks.travis@… Owned by: Brian Rosner
Component: Forms Version: newforms-admin
Severity: Keywords: nfa-blocker
Cc: cmawebsite@… Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There is currently no similar method to ModelForm's save_m2m for saving m2m relationship data after a save(commit=False) on a BaseModelFormSet or BaseInlineFormSet.

Attachments (1)

7230_formset_save_m2m.diff​ (1.5 KB ) - added by Brian Rosner 17 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by Brian Rosner, 17 years ago

Owner: changed from nobody to Brian Rosner
Status: new → assigned
Triage Stage: Unreviewed → Accepted

This makes sense. [7507] made save() on a model formset only return changed instances. That logic should be abstracted out. Providing a save_m2m() on the BaseModelFormSet would make alot of sense.

by Brian Rosner, 17 years ago

Attachment: 7230_formset_save_m2m.diff​ added

comment:2 by Brian Rosner, 17 years ago

Has patch: set
milestone: → 1.0 alpha
Needs documentation: set
Needs tests: set

Attached a patch, but need to add some tests and documentation.

comment:3 by Marc Garcia, 17 years ago

Keywords: nfa-blocker added

I add nfa-blocker keyword as synonym of 1.0 alpha milestone (just for organization).

comment:4 by Collin Anderson, 17 years ago

Cc: cmawebsite@… added

comment:5 by Brian Rosner, 17 years ago

Resolution: → fixed
Status: assigned → closed

(In [7930]) newforms-admin: Fixed #7230 -- Added a save_m2m method to BaseModelFormSet when commit=False is passed to save. Thanks Books Travis for the original report.

comment:6 by Jacob, 14 years ago

milestone: 1.0 alpha

Milestone 1.0 alpha deleted

Note: See TracTickets for help on using tickets.
Back to Top