#7230 closed (fixed)
No save_m2m method on BaseModelFormSet or BaseInlineFormSet
Reported by: | Owned by: | Brian Rosner | |
---|---|---|---|
Component: | Forms | Version: | newforms-admin |
Severity: | Keywords: | nfa-blocker | |
Cc: | cmawebsite@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | yes |
Needs tests: | yes | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
There is currently no similar method to ModelForm's save_m2m for saving m2m relationship data after a save(commit=False) on a BaseModelFormSet or BaseInlineFormSet.
Attachments (1)
Change History (7)
comment:1 by , 16 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Triage Stage: | Unreviewed → Accepted |
by , 16 years ago
Attachment: | 7230_formset_save_m2m.diff added |
---|
comment:2 by , 16 years ago
Has patch: | set |
---|---|
milestone: | → 1.0 alpha |
Needs documentation: | set |
Needs tests: | set |
Attached a patch, but need to add some tests and documentation.
comment:3 by , 16 years ago
Keywords: | nfa-blocker added |
---|
I add nfa-blocker keyword as synonym of 1.0 alpha milestone (just for organization).
comment:4 by , 16 years ago
Cc: | added |
---|
comment:5 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
This makes sense. [7507] made
save()
on a model formset only return changed instances. That logic should be abstracted out. Providing a
save_m2m()
on the
BaseModelFormSet
would make alot of sense.