MultipleChoice fields don't validate when using request.REQUEST

[Daniel Roseman <daniel@…>]

MultipleChoice fields always give a validation error if you instantiate the form using data from request.REQUEST rather than request.POST.

This is because the SelectMultiple widget only uses the getlist() method if the data dictionary is a MultiValueDict, whereas request.REQUEST is a MergeDict.

Patch and tests attached.

[Michael Radziej]

I have one objection about the patch: It always treats a MergeDict like a MultiValueDict. But a MergeDict does not need to be merging MultiValueDicts. If it merges normal dicts, the patch is not appropriate.

Anyway, this is a bug so ==> milestone 1.0

[Malcolm Tredinnick]

I'm not really worried about people passing in a MergeDict of arbitrary dictionaries here. We don't need to publicly support every type of possible data structures, just the normal dictionary case and anything that Django might have to pass in internally. So this approach is fine.

[Malcolm Tredinnick]

(In [8525]) Fixed #7195 -- Fixed the validation of MultipleChoice fields so that they can
be populated from request.REQUEST. Based on a patch from Daniel Roseman.

[Jacob]

Milestone 1.0 deleted