Opened 9 years ago

Closed 8 years ago

#7171 closed (fixed)

Minor code cleanup in django/newforms/models.py

Reported by: Sebastian Noack Owned by: Adrian Holovaty
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

'There is a comment in django/newforms/models.py, that ModelChoiceField._set_choices is copied from ChoiceField, because it is necessary. This is actually not true. Look at my patch.

Attachments (1)

0001-Removed-_set_choices-method-from-ModelChoiceField-w.patch (1.1 KB) - added by Sebastian Noack 9 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 9 years ago by Sebastian Noack

Owner: changed from nobody to Adrian Holovaty

comment:2 Changed 8 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

(In [7644]) Fixed #7171 -- Removed some redundant code in ModelChoiceField. Thanks for the patch, sebastian_noack

Note: See TracTickets for help on using tickets.
Back to Top