Opened 16 years ago
Closed 16 years ago
#7171 closed (fixed)
Minor code cleanup in django/newforms/models.py
| Reported by: | Sebastian Noack | Owned by: | Adrian Holovaty |
|---|---|---|---|
| Component: | Forms | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
'There is a comment in django/newforms/models.py, that ModelChoiceField._set_choices is copied from ChoiceField, because it is necessary. This is actually not true. Look at my patch.
Attachments (1)
Change History (3)
by , 16 years ago
| Attachment: | 0001-Removed-_set_choices-method-from-ModelChoiceField-w.patch added |
|---|
comment:1 by , 16 years ago
| Owner: | changed from to |
|---|
comment:2 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
(In [7644]) Fixed #7171 -- Removed some redundant code in ModelChoiceField. Thanks for the patch, sebastian_noack