Opened 6 years ago

Closed 6 years ago

#7171 closed (fixed)

Minor code cleanup in django/newforms/

Reported by: sebastian_noack Owned by: adrian
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


'There is a comment in django/newforms/, that ModelChoiceField._set_choices is copied from ChoiceField, because it is necessary. This is actually not true. Look at my patch.

Attachments (1)

0001-Removed-_set_choices-method-from-ModelChoiceField-w.patch (1.1 KB) - added by sebastian_noack 6 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 6 years ago by sebastian_noack

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to adrian
  • Patch needs improvement unset

comment:2 Changed 6 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [7644]) Fixed #7171 -- Removed some redundant code in ModelChoiceField. Thanks for the patch, sebastian_noack

Add Comment

Modify Ticket

Change Properties
<Author field>
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.