Opened 17 years ago
Closed 17 years ago
#7132 closed (fixed)
SelectMultiple Widget need's it's own _has_changed method
Reported by: | Alex Gaynor | Owned by: | Brian Rosner |
---|---|---|---|
Component: | Forms | Version: | newforms-admin |
Severity: | Keywords: | newforms | |
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Currently it just uses the parent class(Widget)'s method, which means comparing force_unicode on 2 lists, which doesn't work well, since everywhere else we compare force_unicode on the object, we should be doing it on each element.
Attachments (2)
Change History (5)
comment:1 by , 17 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Triage Stage: | Unreviewed → Accepted |
by , 17 years ago
Attachment: | 7132.selectmultiple-fix.1.diff added |
---|
by , 17 years ago
Attachment: | 7132.selectmultiple-fix.2.diff added |
---|
comment:2 by , 17 years ago
Version: | SVN → newforms-admin |
---|
comment:3 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Looks like post-commit hook did not work. This was fixed in [7515].
Note:
See TracTickets
for help on using tickets.
Added tests on CheckboxSelectMultiple