Code

Opened 6 years ago

Closed 6 years ago

#7132 closed (fixed)

SelectMultiple Widget need's it's own _has_changed method

Reported by: Alex Owned by: brosner
Component: Forms Version: newforms-admin
Severity: Keywords: newforms
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Currently it just uses the parent class(Widget)'s method, which means comparing force_unicode on 2 lists, which doesn't work well, since everywhere else we compare force_unicode on the object, we should be doing it on each element.

Attachments (2)

7132.selectmultiple-fix.1.diff (3.8 KB) - added by brosner 6 years ago.
7132.selectmultiple-fix.2.diff (4.9 KB) - added by Alex 6 years ago.
Added tests on CheckboxSelectMultiple

Download all attachments as: .zip

Change History (5)

comment:1 Changed 6 years ago by brosner

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to brosner
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Accepted

Changed 6 years ago by brosner

Changed 6 years ago by Alex

Added tests on CheckboxSelectMultiple

comment:2 Changed 6 years ago by brosner

  • Version changed from SVN to newforms-admin

comment:3 Changed 6 years ago by brosner

  • Resolution set to fixed
  • Status changed from assigned to closed

Looks like post-commit hook did not work. This was fixed in [7515].

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.