Opened 8 years ago

Closed 8 years ago

#7132 closed (fixed)

SelectMultiple Widget need's it's own _has_changed method

Reported by: Alex Gaynor Owned by: Brian Rosner
Component: Forms Version: newforms-admin
Severity: Keywords: newforms
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


Currently it just uses the parent class(Widget)'s method, which means comparing force_unicode on 2 lists, which doesn't work well, since everywhere else we compare force_unicode on the object, we should be doing it on each element.

Attachments (2)

7132.selectmultiple-fix.1.diff (3.8 KB) - added by Brian Rosner 8 years ago.
7132.selectmultiple-fix.2.diff (4.9 KB) - added by Alex Gaynor 8 years ago.
Added tests on CheckboxSelectMultiple

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 years ago by Brian Rosner

Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to Brian Rosner
Patch needs improvement: unset
Status: newassigned
Triage Stage: UnreviewedAccepted

Changed 8 years ago by Brian Rosner

Changed 8 years ago by Alex Gaynor

Added tests on CheckboxSelectMultiple

comment:2 Changed 8 years ago by Brian Rosner

Version: SVNnewforms-admin

comment:3 Changed 8 years ago by Brian Rosner

Resolution: fixed
Status: assignedclosed

Looks like post-commit hook did not work. This was fixed in [7515].

Note: See TracTickets for help on using tickets.
Back to Top