Opened 17 years ago
Closed 16 years ago
#7061 closed (fixed)
i18n docs contradict actual RequestContext behavior
Reported by: | Antti Kaihola | Owned by: | nobody |
---|---|---|---|
Component: | Documentation | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The i18n.txt documentation says (bold mine):
Each RequestContext
has access to three translation-specific variables:
LANGUAGES
is a list of tuples in which the first element is the language code and the second is the language name (in that language).
However, the languages name seem to actually be in English (with default settings). When this test script is run:
#!/usr/bin/python from django.conf import settings settings.configure() from django.template import RequestContext print '\n'.join('%-5s %s' % l for l in RequestContext(None)['LANGUAGES'])
this is what is output on the terminal:
ar Arabic bn Bengali bg Bulgarian ca Catalan cs Czech cy Welsh da Danish de German el Greek en English es Spanish es-ar Argentinean Spanish eu Basque fa Persian fi Finnish fr French ga Irish gl Galician hu Hungarian he Hebrew hr Croatian is Icelandic it Italian ja Japanese ka Georgian ko Korean km Khmer kn Kannada lv Latvian mk Macedonian nl Dutch no Norwegian pl Polish pt Portugese pt-br Brazilian Portuguese ro Romanian ru Russian sk Slovak sl Slovenian sr Serbian sv Swedish ta Tamil te Telugu tr Turkish uk Ukrainian zh-cn Simplified Chinese zh-tw Traditional Chinese
Attachments (2)
Change History (7)
by , 17 years ago
Attachment: | i18n-doc-requestcontext-languages.diff added |
---|
comment:1 by , 17 years ago
Triage Stage: | Unreviewed → Ready for checkin |
---|
comment:2 by , 17 years ago
Resolution: | → worksforme |
---|---|
Status: | new → closed |
I just did a simple template to print LANGUAGES throught runserver and I got all language names translated to whatever language I set.
Your test case has something rare anyway.. Did you try that via runserver?
Closing as seems invalid unless you can reproduce it in a view (where requestcontext is supposed to be used).
comment:3 by , 16 years ago
I still insist that the documentation suggests the names of the languages should be in each language itself instead of the current active language, e.g.:
- de Deutsch
- en English
- es español
- fi Suomi
- fr français
- no norsk
- sv svenska
I admit that I'm not a native English speaker, so I might have misunderstood the original sentence. In that case, other non-first-language English speakers might misunderstand it as well, and it would make sense to re-phrase.
My patch was of course wrong because it suggested that the language names are always in English. A fixed patch is on its way.
by , 16 years ago
Attachment: | i18n-doc-requestcontext-languages.2.diff added |
---|
corrected correction to i18n documentation
comment:4 by , 16 years ago
Resolution: | worksforme |
---|---|
Status: | closed → reopened |
I misunderstood your description, indeed the documentation reads "Language names in the language of the language name" (more or less). So the real behaviour is not what is documented. Thanks for insisting.
comment:5 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
correction to i18n.txt documentation