Code

Opened 6 years ago

Closed 6 years ago

#7055 closed (fixed)

Join alias sql should not use AS keyword

Reported by: ikelly Owned by: nobody
Component: Core (Other) Version: queryset-refactor
Severity: Keywords: qs-rf
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: UI/UX:

Description

When specifying aliases for joins, the optional keyword 'AS' should not be used. Oracle doesn't like it.

Attachments (1)

join_alias_no_as.diff (1.1 KB) - added by ikelly 6 years ago.

Download all attachments as: .zip

Change History (2)

Changed 6 years ago by ikelly

comment:1 Changed 6 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [7439]) queryset-refactor: Don't use the "AS" keyword in the FROM-clause. Fixed #7055.
Patch from Ian Kelly.

This keyword is optional in SQL, but not permitted by Oracle. If we ever need
to support a backend that requires this keyword at some later date, we can make
it a connection.feature option, but that's overkill for now.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.