Opened 20 years ago

Closed 20 years ago

Last modified 18 years ago

#7 closed defect (fixed)

Patch: Changelist date range filters don't maintain state as expected

Reported by: Wilson Miner Owned by: Adrian Holovaty
Component: contrib.admin Version:
Severity: minor Keywords:
Cc: Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:19168 merged, 18631 merged, 18216 merged, 18062 merged, 17849 unmerged, 17608 merged, 17206 merged, 17135 merged, 16194 merged, 17198 merged, 17024 merged, 16921 unmerged, 17027 merged, 16853 unmerged, 16407 merged, 15829 merged, 2716 unmerged, 156 unmerged, 14940 merged, 14826 merged, 14741 unmerged, 13192 merged, 14133 merged, 14167 merged, 13805 merged, 13915 merged, 13693 merged, 13069 merged, 13075 merged, 11548 merged

Description (last modified by Wilson Miner)

The changelist filter by a date doesn't behave as expected.

What happens: When I click "This month", it correctly displays the objects for this month and drills down the date nav to the appropriate context, but the filter on the right does not indicate which range is currently applied. The "Any date" link does not reset the date drill down.

What should happen: The date filter on the sidebar should update to show which range is currently applied. The "Any date" option should reset the date context. Alternatively, the filter "by date" options could be removed entirely to avoid conflict with the date drilldown.

Change History (5)

comment:1 by Wilson Miner, 20 years ago

Description: modified (diff)
Reporter: changed from Adrian Holovaty to Wilson Miner

comment:2 by Manuzhai, 20 years ago

I think this only happened when there were additional filters defined. The attached patch will fix this.

The issue is that a fieldname is used which is not used in the forloop, so that it will only ever use the last fieldname from an earlier loop.

by Manuzhai, 20 years ago

Attachment: filter.diff added

Get the correct fieldname for the current filter.

comment:3 by Manuzhai, 20 years ago

Summary: Changelist date range filters don't maintain state as expectedPatch: Changelist date range filters don't maintain state as expected

Changing summary to attract developers' attention to this patch.

comment:4 by Adrian Holovaty, 20 years ago

Resolution: fixed
Status: newclosed

(In [417]) Fixed #7 -- Fixed subtle admin changelist filter bug in maintaining state. Thanks for the patch, Manuzhai!

Note: See TracTickets for help on using tickets.
Back to Top