Code

Opened 6 years ago

Last modified 5 years ago

#6992 new Cleanup/optimization

Better error message if Middleware.process_response returns None

Reported by: guettli Owned by: nobody
Component: Core (Other) Version: master
Severity: Normal Keywords:
Cc: hv@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

It is easy to forget the return statement in process_response(). This
little patch results in a better error message.

Attachments (1)

6992.diff (701 bytes) - added by guettli 6 years ago.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by guettli

comment:1 Changed 6 years ago by telenieko

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 5 years ago by SmileyChris

  • Patch needs improvement set

Error message is a wee bit confusing (and is the wsgi handler isn't the only place where this is needed - maybe a small refactor would be good).

comment:3 Changed 3 years ago by julien

  • Severity set to Normal
  • Type set to Cleanup/optimization

comment:4 Changed 2 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:5 Changed 2 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as new
The owner will be changed from nobody to anonymous. Next status will be 'assigned'
as The resolution will be set. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.