newforms BooleanField should be more tolerant of different inputs

[Simon Willison]

Here's how BooleanField works at the moment:

​http://code.djangoproject.com/browser/django/trunk/django/newforms/fields.py#L534

if value == 'False':
    return False
return bool(value)

It would be really nice if it had a slightly more human-friendly idea of what constituted true and false values. For example, '1' v.s. '0', 'true' v.s. 'false', 'yes' v.s. 'no' etc. At the moment it assumes it will only be called from a check box widget, but there are times when this code will be used for input that didn't come from an HTML form.

[Chris Beaven]

Easy to implement, just need a call from core whether we want to do this...

if value.lower() in ('0', 'false', 'no'):
    return False
return bool(value)

[Chris Beaven]

(of course, that was a naive prototype, you should check that value is a string too)

[Andrew Gibson]

one line change plus tests

[Andrew Gibson]

My first attempt at submitting a patch. I know it's not a big deal, was just trying to learn the process. Hope it helps:)

[Chris Beaven]

checking type against str isn't very good

[Chris Beaven]

This is actually a dupe ticket - it was fixed somewhere along the way (for '0' at least)