Opened 17 years ago
Closed 16 years ago
#6857 closed (wontfix)
django.dispatch.robustapply does not work on jython
Reported by: | Leo Soto M. | Owned by: | nobody |
---|---|---|---|
Component: | Core (Other) | Version: | dev |
Severity: | Keywords: | jython pypy | |
Cc: | Triage Stage: | Design decision needed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Currently, pydispatcher expect that every im_func
object contains its corresponding func_code
. That is not always the case, at least on Jython, raising AttributeError
.
Attachments (3)
Change History (8)
by , 17 years ago
Attachment: | robustapply_jython_compatible.patch added |
---|
comment:1 by , 17 years ago
Triage Stage: | Unreviewed → Design decision needed |
---|
comment:2 by , 17 years ago
This would be fixed by #6814. As part of the clean-up/speed-up, robustapply has been removed.
by , 16 years ago
Attachment: | robustapply_pypy_compatible.patch added |
---|
comment:3 by , 16 years ago
I've attached a new patch, that makes robustapply working on cpython, jython and pypy at the same time.
comment:4 by , 16 years ago
Keywords: | pypy added |
---|
I added a test (py.test style, I can move it to unittest style if anyone wants) to prove that robustapply behaves exactly the same everywhere.
comment:5 by , 16 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
#6814 is likely to make it into 1.0 and it gets rid of the slow robust apply stuff. Let's focus our efforts there.
We need to evaluate whether we're going to keep
robust_apply
in the dispatcher refactoring; if not this will be moot, but if so we'll need to take it into account.