Opened 7 years ago

Closed 7 years ago

#6857 closed (wontfix)

django.dispatch.robustapply does not work on jython

Reported by: leosoto Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords: jython pypy
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Currently, pydispatcher expect that every im_func object contains its corresponding func_code. That is not always the case, at least on Jython, raising AttributeError.

Attachments (3)

robustapply_jython_compatible.patch (1.8 KB) - added by leosoto 7 years ago.
robustapply_pypy_compatible.patch (1.3 KB) - added by anto.cuni@… 7 years ago.
test_robustapply.py (1.8 KB) - added by fijal 7 years ago.
Test (py.test) for robustapply

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by leosoto

comment:1 Changed 7 years ago by ubernostrum

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

We need to evaluate whether we're going to keep robust_apply in the dispatcher refactoring; if not this will be moot, but if so we'll need to take it into account.

comment:2 Changed 7 years ago by keithb

This would be fixed by #6814. As part of the clean-up/speed-up, robustapply has been removed.

Changed 7 years ago by anto.cuni@…

comment:3 Changed 7 years ago by anto.cuni@…

I've attached a new patch, that makes robustapply working on cpython, jython and pypy at the same time.

Changed 7 years ago by fijal

Test (py.test) for robustapply

comment:4 Changed 7 years ago by fijal

  • Keywords pypy added

I added a test (py.test style, I can move it to unittest style if anyone wants) to prove that robustapply behaves exactly the same everywhere.

comment:5 Changed 7 years ago by gwilson

  • Resolution set to wontfix
  • Status changed from new to closed

#6814 is likely to make it into 1.0 and it gets rid of the slow robust apply stuff. Let's focus our efforts there.

Note: See TracTickets for help on using tickets.
Back to Top