Opened 9 years ago

Closed 9 years ago

#6852 closed (fixed)

DeprecationWarning in admin, caused by recent changes to pagination

Reported by: Nick Efford Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords: admin, pagination
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The admin app uses the old ObjectPaginator class, which triggers DeprecationWarning as of [7306]. The attached patch, against trunk, tweaks admin to use the new API. It seems to work OK as far I as can see, but wiser heads than mine will need to verify :)

Note that this is against trunk, not newforms-admin, as the latter hasn't merged in the new pagination code yet.

Feel free to wontfix if you think we can live with warnings until newforms-admin arrives. In any case, the patch might be useful to newforms-admin devs as the basis of a proper, long-term solution.

Attachments (1)

admin_pagination.diff (3.9 KB) - added by Nick Efford 9 years ago.
Fixes to pagination code of admin app

Download all attachments as: .zip

Change History (2)

Changed 9 years ago by Nick Efford

Attachment: admin_pagination.diff added

Fixes to pagination code of admin app

comment:1 Changed 9 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

(In [7363]) Fixed #6852 -- Converted the admin to use the new paginator, to remove DeprecationWarnings. Thanks for the patch, nickefford

Note: See TracTickets for help on using tickets.
Back to Top