Opened 6 years ago

Closed 6 years ago

#6852 closed (fixed)

DeprecationWarning in admin, caused by recent changes to pagination

Reported by: nickefford Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords: admin,pagination
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: UI/UX:


The admin app uses the old ObjectPaginator class, which triggers DeprecationWarning as of [7306]. The attached patch, against trunk, tweaks admin to use the new API. It seems to work OK as far I as can see, but wiser heads than mine will need to verify :)

Note that this is against trunk, not newforms-admin, as the latter hasn't merged in the new pagination code yet.

Feel free to wontfix if you think we can live with warnings until newforms-admin arrives. In any case, the patch might be useful to newforms-admin devs as the basis of a proper, long-term solution.

Attachments (1)

admin_pagination.diff (3.9 KB) - added by nickefford 6 years ago.
Fixes to pagination code of admin app

Download all attachments as: .zip

Change History (2)

Changed 6 years ago by nickefford

Fixes to pagination code of admin app

comment:1 Changed 6 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [7363]) Fixed #6852 -- Converted the admin to use the new paginator, to remove DeprecationWarnings. Thanks for the patch, nickefford

Add Comment

Modify Ticket

Change Properties
<Author field>
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.