contrib.auth.forms is inconsistent on form field labels and max_length

[Bela Hausmann <post@…>]

Not all fields have appropriate labels, also max_length on passwords fields differs from form to form (I set it all to 30, like in the model definitions). Also the email field should have the same max_length like the model (which is none/default). See patch.

[Bela Hausmann <post@…>]

django.contrib.auth.forms patch

[Jeff Anderson]

All the fields have had labels added since this ticket was opened.

The inconsistency of the 'max_length' being set to 30 or 60 is still there.

Is there a reason that the lengths were set to 60?

I'm going to write up a patch that applies cleanly that changes all the values to 30.

[Brian Rosner]

Someone correct me if I am wrong, but the values that are set for max_length on the forms in django.contrib.auth.forms are correctly mirrored from trunk. There may be a presentation issue, but surely it allowed 60 characters. This would limit them to 30.

[Jeff Anderson]

It did mirror the way that the form was in trunk, yes. This ticket was opened because the form wasn't consistent with what the models specified. I am digging in and verifying this. According to the model definition, a username should only be 30 characters, a password 128, and an e-mail doesn't have an explicit limit defined in the model.

I don't think that my latest patch reflects those numbers exactly, but the form probably should reflect the model's limits.

[Thejaswi Puthraya]

Most of this seems to have already been fixed in the current trunk. I am closing this
ticket.