Opened 7 years ago

Closed 7 years ago

#6809 closed (fixed)

[newforms-admin] non_field_errors are not displayed in change_form.html

Reported by: peschler Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Keywords: nfa-blocker non_field_errors form admin
Cc: framos@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Error messages that don't belong to a field (=form.non_field_errors) are not displayed at the top of the form in the admin change view of a model.

E.g. error messages issued by a custom Form's clean() method are not displayed to the user.

Attached is a simple patch to the change_form.html which fixes the problem and displays all non-field error messages at the top of the form.

Attachments (1)

change_form-non_field_errors.diff (662 bytes) - added by peschler 7 years ago.
Patch for displaying non_field_errors.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by peschler

Patch for displaying non_field_errors.

comment:1 Changed 7 years ago by peschler

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Summary changed from non_field_errors are not displayed in change_form.html to [newforms-admin] non_field_errors are not displayed in change_form.html

comment:2 Changed 7 years ago by brosner

  • Keywords nfa-blocker added
  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 7 years ago by framos

  • Cc framos@… added

comment:4 Changed 7 years ago by brosner

  • Resolution set to fixed
  • Status changed from new to closed

(In [7607]) newforms-admin: Fixed #6809 -- non_field_errors are now properly displayed. Thanks peschler.

Note: See TracTickets for help on using tickets.
Back to Top