Code

Opened 6 years ago

Closed 6 years ago

#6784 closed (invalid)

"is_public yes" doesn't work in template tag "comment_form"

Reported by: Bela Hausmann <post@…> Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description (last modified by ramiro)

the error is in django/contrib/comments/templatetags/comments.py, line 209:

kwargs[option] = (args == 'true')

it should be:

kwargs[option] = (args == 'yes')

or the example usage in the docstring should be corrected

Attachments (1)

6784.patch (796 bytes) - added by mk 6 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 6 years ago by anonymous

  • Has patch unset
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 6 years ago by ramiro

  • Description modified (diff)

Changed 6 years ago by mk

comment:3 Changed 6 years ago by mk

  • Has patch set

comment:4 Changed 6 years ago by jacob

  • Resolution set to invalid
  • Status changed from new to closed

With the new comment system added in [8557], I'm closing all comment-related tickets since they're against an old system. Please open a new ticket for this issue if it still applies in the new system.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.