Opened 16 years ago

Closed 12 years ago

#6749 closed Bug (duplicate)

Generic week view displays Sunday objects in both the current and next week

Reported by: Jim Garrison Owned by: nobody
Component: Generic views Version: dev
Severity: Normal Keywords: archive_week
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description (last modified by Ramiro Morales)

Objects on a Sunday are mistakenly displayed in both the correct week and the previous week.

The relevant code from django/views/generic/date_based.py (function archive_week):

    # Calculate first and last day of week, for use in a date-range lookup.
    first_day = date
    last_day = date + datetime.timedelta(days=7)
    lookup_kwargs = {'%s__range' % date_field: (first_day, last_day)}

first_day is set from date, which is the Sunday that begins the week. However, last_day is then set to be the day 7 days after that day, which is the next Sunday. The final line above sets the range to be from one Sunday to the next Sunday, but the range test is inclusive so both Sundays are included by mistake.

This bug can be fixed by changing the 7 to a 6. Trivial patch is attached.

Attachments (1)

week_view.diff​ (621 bytes ) - added by Jim Garrison 16 years ago.

Download all attachments as: .zip

Change History (7)

by Jim Garrison, 16 years ago

Attachment: week_view.diff​ added

comment:1 by Pete Crosier, 16 years ago

Keywords: archive_week added
Summary: Generic week view displays Sunday objects in both the current and previous week → Generic week view displays Sunday objects in both the current and next week
Triage Stage: Unreviewed → Accepted

Seems like a simple error, changed what I guess was a type in the title too (extra Sunday used is in the next week).

comment:2 by Ramiro Morales, 16 years ago

Description: modified (diff)

comment:3 by Chris Beaven, 15 years ago

Needs tests: set

comment:4 by Russell Keith-Magee, 14 years ago

Patch needs improvement: set

Needs to be updated for class-based views.

comment:5 by Julien Phalip, 13 years ago

Severity: → Normal
Type: → Bug

comment:6 by Koen Biermans, 12 years ago

Easy pickings: unset
Resolution: → duplicate
Status: new → closed
UI/UX: unset

It seems this was already fixed in r8476 (fix for #7602).

Closing as duplicate.

Note: See TracTickets for help on using tickets.
Back to Top