#6655 closed (wontfix)
Very little refactoring of get_svn_revision()
| Reported by: | Ivan Illarionov | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Other) | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Just fewer lines of code that do the same thing more clear (in my opinion).
Attachments (1)
Change History (3)
Changed 16 years ago by
| Attachment: | svnrevision.patch added |
|---|
comment:1 Changed 16 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
comment:2 Changed 16 years ago by
Certainly, this is a personal preference. I reused this Django function in a different project and couldn't stop myself from changing it a little. I completely don't mind if core Django devs have a different vision.
Note: See
TracTickets for help on using
tickets.
Probably not worth it. Realising that changes like this are always going to be personal preference, I feel that this type of change obscures the fact that path could be empty.
Opinions vary wildly in the Python community about this type of construct (PEP 308 showing how inconclusive the consensus is).