Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#6655 closed (wontfix)

Very little refactoring of get_svn_revision()

Reported by: i_i Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


Just fewer lines of code that do the same thing more clear (in my opinion).

Attachments (1)

svnrevision.patch (797 bytes) - added by i_i 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by i_i

comment:1 Changed 8 years ago by mtredinnick

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to wontfix
  • Status changed from new to closed

Probably not worth it. Realising that changes like this are always going to be personal preference, I feel that this type of change obscures the fact that path could be empty.

Opinions vary wildly in the Python community about this type of construct (PEP 308 showing how inconclusive the consensus is).

comment:2 Changed 8 years ago by i_i

Certainly, this is a personal preference. I reused this Django function in a different project and couldn't stop myself from changing it a little. I completely don't mind if core Django devs have a different vision.

Note: See TracTickets for help on using tickets.
Back to Top