included template blocks are not being overridden by parent template.

[anonymous]

When including a template into a parent template, the child-template's blocks are not overridden by the parent.

For example:

base.html:

{% if is_satchmo %}
{% include "satchmo_base.html" %}
{% else %}
{% include "journal_base.html" %}
{% endif %}

journal_base.html contains the following block:

{% block content%}{% endblock %}

view_template.html extends base.html (with the context variable is_satchmo == False). view_template.html contains {% block content%}{% endblock %} which should filled with data from the view's context variable.

If I rename journal_base.html to base.html - everything works fine - but when I use the version of base.html that relies on the include tag, {% block content %} doesn't get overridden.

The documentation says that context vairables are available to included templates, so not being able to override blocks seems like a bug.

[Collin Grady <cgrady@…>]

Context variables have nothing to do with blocks - as far as I'm aware this is just how the template system works - included templates cannot be extended.

[edgarsj]

Probably documentation needs to clarify this.

[miracle2k]

Related django-dev thread:

​http://groups.google.com/group/django-developers/browse_thread/thread/796489b6f29440e4

[miracle2k]

includes tests

[cornbread]

Why is this documentation? When can we see it in trunk?

[Collin Grady]

it is documentation because it is not supposed to work - as such, it needs documented that this is the case, so that people don't think it's a bug

[walpatal]

I've been biten by this enough times to take a stab solving it.

[Chris Beaven]

There's no reason this can't work (for static include blocks), so I'm switching the component back to "template system".

I've attached an updated patch which does it a bit safer than miracle2k's way (the way that Node.get_nodes_by_type() works, if nodelist attribute is there, it currently assumes it's a NodeList and not None so a nodelist property doesn't work)
We do need some documentation to say that dynamic include blocks won't be extended. Wanna write something up walpatal?

[Marco Paolini]

a different but somewhat related feature is selective include tag #11832

[Thomas Steinacher <tom@…>]

The patch is working for me. Any reason this is not in trunk yet?

[Luke Plant]

Replying to Thomas Steinacher <tom@eggdrop.ch>:

The patch is working for me. Any reason this is not in trunk yet?

Without docs for the point SmileyChris mentioned it won't go in. Also, I suspect that fixing #12064 would break this patch, because it effectively makes all include blocks 'dynamic' i.e. the actual template used is decided at render time, not compile time. If my suspicions are correct, then there are definitely some design decisions to be made.

[Aymeric Augustin]

The design decision on ticket 12008 states that blocks are evaluated before includes.

As a consequence, the behavior should not be changed here.