Opened 16 years ago

Closed 12 years ago

#6610 closed New feature (duplicate)

don't hardcode flup fastcgi traceback off

Reported by: jedie Owned by: Michael Kurze
Component: Core (Other) Version: dev
Severity: Normal Keywords: fastCGI, flup
Cc: django@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

In [4170] the flup traceback are hardcoded turn off. I think this is not the best way.
The Traceback should be per default disable. But it should be possible to turn the traceback on via runfastcgi() options.

Attachments (2)

patch.txt (678 bytes ) - added by jedie 16 years ago.
trac-6610.diff (2.1 KB ) - added by Michael Kurze 16 years ago.
Allow to specify a debug parameter to runfcgi that is passed to flup and allows for traceback pages. Default is False.

Download all attachments as: .zip

Change History (10)

by jedie, 16 years ago

Attachment: patch.txt added

comment:1 by jedie, 16 years ago

Cc: django@… added

comment:2 by Philippe Raoult, 16 years ago

Needs documentation: set
Patch needs improvement: set

It seems your patch doesn't allow setting the option. The value gets lost because it sits in fcgi_options and is never copied to wsgi_options. Plus you didn't document the extra command-line argument.

comment:3 by Jeff Anderson, 16 years ago

Triage Stage: UnreviewedAccepted

by Michael Kurze, 16 years ago

Attachment: trac-6610.diff added

Allow to specify a debug parameter to runfcgi that is passed to flup and allows for traceback pages. Default is False.

comment:4 by Michael Kurze, 16 years ago

Needs documentation: unset
Patch needs improvement: unset

I updated my patch to include documentation.

comment:5 by Michael Kurze, 16 years ago

Owner: changed from nobody to Michael Kurze
Status: newassigned

comment:6 by Julien Phalip, 13 years ago

Type: New feature

comment:7 by patchhammer, 13 years ago

Easy pickings: unset
Patch needs improvement: set
Severity: Normal

trac-6610.diff fails to apply cleanly on to trunk

comment:8 by Claude Paroz, 12 years ago

Resolution: duplicate
Status: assignedclosed
UI/UX: unset

Duplicate of #8895

Note: See TracTickets for help on using tickets.
Back to Top