USStateField - newforms - problems
|Reported by:||Purdea Andrei||Owned by:||Purdea Andrei|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||yes||Patch needs improvement:||yes|
The problem appears with the newforms representation of USStateField.
There was absolutely no handling for the case when blank=True. (or with other words required=False).
These modification take the implementation closer to the implementation of ModelChoiceField (the one used for ForeignKey).
- there is an empty_label parameter that is set to u'---------' by default
- i removed the specialized widget, because no such widget was needed
- modified the formfield method accordingly
This bug appears both in trunk and in the newforms-admin branch, the patch can safely be applyed to both.
Change History (4)
comment:1 Changed 9 years ago by
|Patch needs improvement:||unset|