Opened 7 years ago

Closed 7 years ago

#6560 closed (invalid)

@vary_on_cookie does not seem to be working for Safari

Reported by: benjamin.golub@… Owned by: nobody
Component: Core (Cache system) Version: master
Severity: Keywords: vary_on_cookie, memcache, CacheMiddleware
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

You can see this live at http://www.rssmeme.com/.

Nearly every view has @vary_on_cookie on it the whole site is cached using CacheMiddleware with memcache. So when you first hit http://www.rssmeme.com/ you don't have a cookie set and get the cached version. Then when you click the link to set your preview type: http://rssmeme.com/set/preview/none/?next=/ I set a session variable with your preview type.

In Firefox and IE you are now being served uncached data because of the @vary_on_cookie decorator. Safari continues to serve up cached data though so it feels like clicking on the links does nothing; this sucks for my users.

Change History (3)

comment:1 Changed 7 years ago by Benjamin Golub <benjamin.golub@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 7 years ago by Benjamin Golub <benjamin.golub@…>

No longer in use at http://www.rssmeme.com/ (switched to using low level caching to avoid this behavior) but it should still be considered.

comment:3 Changed 7 years ago by PhiR

  • Resolution set to invalid
  • Status changed from new to closed

Are you sure safari actually sent cookies ? If it works in IE AND Firefox it's likely a safari issue then. Closing until you can show us more.

Note: See TracTickets for help on using tickets.
Back to Top