Opened 16 years ago

Closed 14 years ago

#6508 closed (fixed)

contrib.syndication feed links break with https-urls

Reported by: Ville Säävuori Owned by: nobody
Component: contrib.syndication Version: dev
Severity: Keywords: url, feeds, https, syndication, contrib.syndication
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The current add_domain-method checks if the link URL starts with 'http://' so it breaks with URLs that start with 'https://'.

I searched for previous mentions about this bug but didn't find any tickets. Attached one-line patch changes the method so that it checks both http and https.

Attachments (1)

add_domain.diff​ (580 bytes) - added by Ville Säävuori 16 years ago.
Fixed diff root

Download all attachments as: .zip

Change History (5)

Changed 16 years ago by Ville Säävuori

Attachment: add_domain.diff​ added

Fixed diff root

comment:1 Changed 16 years ago by Simon Greenhill <dev@…>

Triage Stage: Unreviewed → Ready for checkin

comment:2 Changed 16 years ago by Gary Wilson

Resolution: → fixed
Status: new → closed

(In [7050]) Fixed #6508 -- Fixed add_domain function to also work with https feed URLs, thanks Uninen.

comment:3 Changed 14 years ago by Zeth

Resolution: fixed
Status: closed → reopened

This patch drops feed links to HTTP, it does not cope with when the site is only served through HTTPS.

Surely it is better to either not add the ​http:// or be smarter and figure out what it is supposed to add (i.e. add ​https:// when required)?

comment:4 Changed 14 years ago by Alex Gaynor

Resolution: → fixed
Status: reopened → closed

This ticket was fixed 18 months ago, if you believe there is a new issue please file a new ticket.

Note: See TracTickets for help on using tickets.
Back to Top