Code

Opened 6 years ago

Closed 5 years ago

#6508 closed (fixed)

contrib.syndication feed links break with https-urls

Reported by: Uninen Owned by: nobody
Component: contrib.syndication Version: master
Severity: Keywords: url, feeds, https, syndication, contrib.syndication
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The current add_domain-method checks if the link URL starts with 'http://' so it breaks with URLs that start with 'https://'.

I searched for previous mentions about this bug but didn't find any tickets. Attached one-line patch changes the method so that it checks both http and https.

Attachments (1)

add_domain.diff (580 bytes) - added by Uninen 6 years ago.
Fixed diff root

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Uninen

Fixed diff root

comment:1 Changed 6 years ago by Simon Greenhill <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 6 years ago by gwilson

  • Resolution set to fixed
  • Status changed from new to closed

(In [7050]) Fixed #6508 -- Fixed add_domain function to also work with https feed URLs, thanks Uninen.

comment:3 Changed 5 years ago by zeth

  • Resolution fixed deleted
  • Status changed from closed to reopened

This patch drops feed links to HTTP, it does not cope with when the site is only served through HTTPS.

Surely it is better to either not add the http:// or be smarter and figure out what it is supposed to add (i.e. add https:// when required)?

comment:4 Changed 5 years ago by Alex

  • Resolution set to fixed
  • Status changed from reopened to closed

This ticket was fixed 18 months ago, if you believe there is a new issue please file a new ticket.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.