Opened 16 years ago

Closed 16 years ago

#6494 closed (fixed)

Split off traceback HTML generation

Reported by: Bastian Kleineidam <calvin@…> Owned by: Jacob
Component: Uncategorized Version: dev
Severity: Keywords: easy-pickings
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The traceback HTML generation is a useful function by itself. So
split it off ina separate function.

Attachments (2)

0035-Split-off-traceback-HTML-generation.patch​ (1.5 KB ) - added by Bastian Kleineidam <calvin@…> 16 years ago.
6494.diff​ (1.0 KB ) - added by Thejaswi Puthraya 16 years ago.
made changes suggested by SmileyChris

Download all attachments as: .zip

Change History (7)

by Bastian Kleineidam <calvin@…>, 16 years ago

Attachment: 0035-Split-off-traceback-HTML-generation.patch​ added

comment:1 by Chris Beaven, 16 years ago

Patch needs improvement: set
Triage Stage: Unreviewed → Accepted

Agreed. Very minor style change: def get_traceback_html (request, exc_type, exc_value, tb): should be def get_traceback_html(request, exc_type, exc_value, tb):

comment:2 by Chris Beaven, 16 years ago

Keywords: easy-pickings added

by Thejaswi Puthraya, 16 years ago

Attachment: 6494.diff​ added

made changes suggested by SmileyChris

comment:3 by Thejaswi Puthraya, 16 years ago

Patch needs improvement: unset

comment:4 by Jacob, 16 years ago

Owner: changed from nobody to Jacob
Triage Stage: Accepted → Ready for checkin

comment:5 by Malcolm Tredinnick, 16 years ago

Resolution: → fixed
Status: new → closed

(In [7292]) Fixed #6494 -- Factored out the HTML debug output into a method of its own for
reuse elsewhere. Thanks, Bastian Kleineidam.

Note: See TracTickets for help on using tickets.
Back to Top