Code

Opened 6 years ago

Closed 6 years ago

#6494 closed (fixed)

Split off traceback HTML generation

Reported by: Bastian Kleineidam <calvin@…> Owned by: jacob
Component: Uncategorized Version: master
Severity: Keywords: easy-pickings
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The traceback HTML generation is a useful function by itself. So
split it off ina separate function.

Attachments (2)

0035-Split-off-traceback-HTML-generation.patch (1.5 KB) - added by Bastian Kleineidam <calvin@…> 6 years ago.
6494.diff (1.0 KB) - added by thejaswi_puthraya 6 years ago.
made changes suggested by SmileyChris

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by Bastian Kleineidam <calvin@…>

comment:1 Changed 6 years ago by SmileyChris

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

Agreed. Very minor style change: def get_traceback_html (request, exc_type, exc_value, tb): should be def get_traceback_html(request, exc_type, exc_value, tb):

comment:2 Changed 6 years ago by SmileyChris

  • Keywords easy-pickings added

Changed 6 years ago by thejaswi_puthraya

made changes suggested by SmileyChris

comment:3 Changed 6 years ago by thejaswi_puthraya

  • Patch needs improvement unset

comment:4 Changed 6 years ago by jacob

  • Owner changed from nobody to jacob
  • Triage Stage changed from Accepted to Ready for checkin

comment:5 Changed 6 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [7292]) Fixed #6494 -- Factored out the HTML debug output into a method of its own for
reuse elsewhere. Thanks, Bastian Kleineidam.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.