Code

Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#6491 closed (invalid)

Improvements to User and Permission models

Reported by: Bastian Kleineidam <calvin@…> Owned by: nobody
Component: Uncategorized Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The Permission model increases the maximal permission name length
from 50 to 100 (I actually hit this limit with some model permission
names some of my projects).
The User model will be sorted by last name, first name and then
username. And the string representation of a user will include the
last and first name if defined.

Attachments (1)

0019-Improvements-to-User-and-Permission-models.patch (1.9 KB) - added by Bastian Kleineidam <calvin@…> 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Bastian Kleineidam <calvin@…>

comment:1 Changed 6 years ago by mtredinnick

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

These are two unrelated changes, so should really have been two tickets.

The Permissions one would be nice to have, but is backwards incompatible, so we need to judge the right moment to include it. Shouldn't be too harmful, though, and can be included in the list of database changes required to go from 0.96 to 1.0.

The User changes are a little less clear. The extra ordering is very much personal preference and adds a small performance hit. I don't see a huge need for that. Similarly, the string format change is a bit "take it or leave it" -- again, some people want one thing, others are going to want something else. Probably not worth changing just so that things continue to display as they always have. There are very few cases where you're going to be forced to use Django's version of the string format and cannot replace it with your own if you want (admin might be one place, but we have to make a trade-off in those cases).

So, I'm +1 on the Permissions changes and -1 or -0 on the User changes at the moment, at a first impression.

comment:2 Changed 6 years ago by anonymous

  • milestone set to 1.0

comment:3 Changed 6 years ago by juliae

  • Resolution set to invalid
  • Status changed from new to closed

Splitting into one separate ticket. ref: #8162

comment:4 Changed 3 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.