Opened 8 years ago

Closed 7 years ago

#6465 closed (fixed)

MergeDict only calls getlist on its first merged dict

Reported by: mattmcc Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords: multivaluedict mergedict
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Since MultiValueDict.getlist doesn't raise a KeyError, MergeDict.getlist will only call getlist() on its first dict. This results in request.REQUEST being unable to retrieve a list of values from request.GET.

Attachments (1)

6465-1.diff (1.3 KB) - added by mattmcc 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by mattmcc

comment:1 Changed 8 years ago by mattmcc

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 7 years ago by SmileyChris

  • Triage Stage changed from Unreviewed to Ready for checkin

comment:3 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [7062]) Fixed #6465 -- Tweaked MergeDict.getlist() to work with Django's MultiValueDict class. Thanks, Matt McClanahan.

Note: See TracTickets for help on using tickets.
Back to Top