Opened 17 years ago
Closed 14 years ago
#6453 closed (wontfix)
Explicitly requested fields (i.e. Meta: fields = [...]) should be included in a ModelForm whether they are editable or not
| Reported by: | Chris Beaven | Owned by: | nobody |
|---|---|---|---|
| Component: | Forms | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | yes | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
This a backwards incompatible change and probably debatable (but it obviously makes sense to me).
See patch.
Attachments (1)
Change History (4)
by , 17 years ago
comment:1 by , 17 years ago
| Needs tests: | set |
|---|---|
| Triage Stage: | Unreviewed → Design decision needed |
comment:2 by , 17 years ago
| Triage Stage: | Design decision needed → Ready for checkin |
|---|
comment:3 by , 14 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Even though it would be nice, unfortunately it's a backwards incompatible change. It hasn't been something that has been brought up in my memory since this ticket was opened so I am going to close as a "soft" wontfix.
If someone thinks this could be useful still, an alternate approach would be to propose a method which determined whether a field should be included (this could then be overridden by a subclass to implement the functionality of this ticket).
Note:
See TracTickets
for help on using tickets.
Sounds reasonable. The "editable" attribute is a presentation-related Admin artefact, so being able to override it isn't a bad idea. The default behaviour's good, too.