Opened 8 years ago

Closed 6 years ago

#6453 closed (wontfix)

Explicitly requested fields (i.e. Meta: fields = [...]) should be included in a ModelForm whether they are editable or not

Reported by: SmileyChris Owned by: nobody
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: UI/UX:


This a backwards incompatible change and probably debatable (but it obviously makes sense to me).

See patch.

Attachments (1)

6453.diff (886 bytes) - added by SmileyChris 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by SmileyChris

comment:1 Changed 8 years ago by SmileyChris

  • Needs documentation unset
  • Needs tests set
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:2 Changed 8 years ago by mtredinnick

  • Triage Stage changed from Design decision needed to Ready for checkin

Sounds reasonable. The "editable" attribute is a presentation-related Admin artefact, so being able to override it isn't a bad idea. The default behaviour's good, too.

comment:3 Changed 6 years ago by SmileyChris

  • Resolution set to wontfix
  • Status changed from new to closed

Even though it would be nice, unfortunately it's a backwards incompatible change. It hasn't been something that has been brought up in my memory since this ticket was opened so I am going to close as a "soft" wontfix.

If someone thinks this could be useful still, an alternate approach would be to propose a method which determined whether a field should be included (this could then be overridden by a subclass to implement the functionality of this ticket).

Note: See TracTickets for help on using tickets.
Back to Top