postgres backend doesn't accept version number 8.3RC2

[Trevor Caira]

the postgres backend expects the parts of the postgres version number as reported by select version() to be both integers. however this is not always the case:

trevor=> select version();
                                                     version                                                     
-----------------------------------------------------------------------------------------------------------------
 PostgreSQL 8.3RC2 on x86_64-pc-linux-gnu, compiled by GCC cc (GCC) 4.2.3 20080114 (prerelease) (Debian 4.2.2-7)
(1 row)

the fix is trivial, however. see attached.

[Tom Vergote]

duplicate of #6236.

[Simon Greenhill <dev@…>]

I'll reopen this one in favor of #6236, as this has a patch already.

[brettp]

The patch has a small issue in that with the string suggested in the ticket you'd get a postgres_version of [8, 33] which is, err, obviously wrong, though I'm not entirely sure what the correct answer would be to that - if we could gaurantee that the string RC was going to be in the RC versions, then we could do a check for RC in the version string, then take one off the version before it.

Otherwise, we could just ditch anything after the first character that's not a digit or a period, then parse that, which would give [8, 3] in this case. That might be a better solution.

[James Bennett]

Reverting status per above comment.

[Trevor Caira]

This patch just grabs the first \d+\.\d+ in select version() and calls that the version number.

[brettp]

Patch for postgres version that keeps with previous behaviour on "regular" version numbers and works with beta/RC versions

[brettp]

Removed patch-need-improvement property as there's a new patch that hasn't been reviewed yet.

[Russell Keith-Magee]

This problem has been duplicated as #6987 and #6954; these reports are about the release veresion of the 8.3 version number for Windows builds. #6987 contains a patch that might be useful.

[Jason Erickson]

A new patch that works with RC/beta versions and Windows version strings

[Jason Erickson]

Attached file postgres-versions.diff, modeled very similarly after the MySQL version check, that works for the windows version string as well as if the version string does not have a patch level (like in the above mentioned example).

[Malcolm Tredinnick]

I don't have any way to test this on Windows or an 8.3 beta version, but it looks fairly correct, so I'll commit a small variation on it and we can sort out the damage as people use it.

[Malcolm Tredinnick]

(In [7415]) Fixed #6433 -- Handle some varied PostgreSQL version strings (beta versions and
Windows version strings). Patch from jerickso.